mirror/outline
1
0
Fork 0
mirror of https://github.com/outline/outline.git synced 2025-12-30 07:19:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: Internal URL detection on client, closes #7245

Browse Source
This commit is contained in:
Tom Moor
2024-09-14 11:46:42 -04:00
parent e6ba84e434
commit 5116147ace
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shared/utils/urls.test.ts
View File

@@ -59,6 +59,10 @@ describe("isInternalUrl", () => {
expect(urlsUtils.isInternalUrl("https://example.com:4000")).toBe(false);
});
it("should return false if port is missing", () => {
expect(urlsUtils.isInternalUrl("https://example.com")).toBe(false);
});
it("should return true if starting with relative path", () => {
expect(urlsUtils.isInternalUrl("/drafts")).toEqual(true);
});

4
shared/utils/urls.ts
View File

@@ -37,7 +37,9 @@ export function isInternalUrl(href: string) {
return (
(outline.host === domain.host && outline.port === domain.port) ||
(typeof window !== "undefined" && window.location.hostname === domain.host)
(typeof window !== "undefined" &&
window.location.hostname === domain.host &&
window.location.port === domain.port)
);
}