From abb38ea4471f57bdeb79720c7340ca549effdceb Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Sat, 15 Jul 2023 23:04:30 -0400 Subject: [PATCH] fix: Server error with invalid Prosemirror JSON should be validation error --- server/models/validators/TextLength.ts | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/server/models/validators/TextLength.ts b/server/models/validators/TextLength.ts index f212f566d1..a22d235b75 100644 --- a/server/models/validators/TextLength.ts +++ b/server/models/validators/TextLength.ts @@ -22,10 +22,16 @@ export default function TextLength({ addAttributeOptions(target, propertyName, { validate: { validLength(value: ProsemirrorData) { - const text = ProsemirrorHelper.toPlainText( - Node.fromJSON(schema, value), - schema - ); + let text; + + try { + text = ProsemirrorHelper.toPlainText( + Node.fromJSON(schema, value), + schema + ); + } catch (err) { + throw new Error("Invalid data"); + } if (size(text) > max || size(text) < min) { throw new Error(msg);