From cce22bcdeed6de205dcbd06de606d88128bcb673 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Tue, 4 Jul 2023 08:26:47 -0400 Subject: [PATCH] fix: Embed with underscore in url fails when hydrating from Markdown --- shared/editor/nodes/Embed.tsx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/shared/editor/nodes/Embed.tsx b/shared/editor/nodes/Embed.tsx index 4ed1f57fc2..e42ee8cf4b 100644 --- a/shared/editor/nodes/Embed.tsx +++ b/shared/editor/nodes/Embed.tsx @@ -127,12 +127,11 @@ export default class Embed extends Node { if (!state.inTable) { state.ensureNewLine(); } + + const href = node.attrs.href.replace(/_/g, "%5F"); + state.write( - "[" + - state.esc(node.attrs.href, false) + - "](" + - state.esc(node.attrs.href, false) + - ")" + "[" + state.esc(href, false) + "](" + state.esc(href, false) + ")" ); if (!state.inTable) { state.write("\n\n");