Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

plugins/webhooks/client/Settings.tsx

@@ -9,7 +9,6 @@ import Heading from "~/components/Heading";
 import Modal from "~/components/Modal";
 import PaginatedList from "~/components/PaginatedList";
 import Scene from "~/components/Scene";
-import Subheading from "~/components/Subheading";
 import Text from "~/components/Text";
 import env from "~/env";
 import useBoolean from "~/hooks/useBoolean";
@@ -55,8 +54,15 @@ function Webhooks() {
       </Text>
       <PaginatedList
         fetch={webhookSubscriptions.fetchPage}
-        items={webhookSubscriptions.orderedData}
-        heading={<Subheading sticky>{t("Webhooks")}</Subheading>}
+        items={webhookSubscriptions.enabled}
+        heading={<h2>{t("Active")}</h2>}
+        renderItem={(webhook: WebhookSubscription) => (
+          <WebhookSubscriptionListItem key={webhook.id} webhook={webhook} />
+        )}
+      />
+      <PaginatedList
+        items={webhookSubscriptions.disabled}
+        heading={<h2>{t("Inactive")}</h2>}
         renderItem={(webhook: WebhookSubscription) => (
           <WebhookSubscriptionListItem key={webhook.id} webhook={webhook} />
         )}

plugins/webhooks/client/components/WebhookSubscriptionListItem.tsx

@@ -45,7 +45,7 @@ const WebhookSubscriptionListItem = ({ webhook }: Props) => {
         <>
           {webhook.name}
           {!webhook.enabled && (
-            <StyledBadge yellow={true}>{t("Disabled")}</StyledBadge>
+            <StyledBadge yellow>{t("Disabled")}</StyledBadge>
           )}
         </>
       }

plugins/webhooks/server/api/webhookSubscriptions.ts

@@ -106,6 +106,10 @@ router.post(
       ip: ctx.request.ip,
     };
     await Event.create(event);
+
+    ctx.body = {
+      success: true,
+    };
   }
 );