fix: copy pasting the content from some medium into outline does not get the images (#8472)

* fix: Files from local storage provider sometimes returned with incorrect content type

* fix: attachments.createFromUrl response values incorrect for successful upload

* fix: Reduce liklihood of image download requests being blocked on server

* fix: Content with HTML images should never be considered as markdown

* fix: Image caption sometimes uncentered

* test

plugins/storage/server/api/files.test.ts

@@ -236,7 +236,16 @@ describe("#files.get", () => {
   it("should succeed with status 200 ok when file is requested using signature", async () => {
     const user = await buildUser();
     const fileName = "images.docx";
-    const key = path.join("uploads", user.id, uuidV4(), fileName);
+    const { key } = await buildAttachment(
+      {
+        teamId: user.teamId,
+        userId: user.id,
+        contentType:
+          "application/vnd.openxmlformats-officedocument.wordprocessingml.document",
+        acl: "private",
+      },
+      fileName
+    );
     const signedUrl = await FileStorage.getSignedUrl(key);
 
     ensureDirSync(
@@ -262,6 +271,13 @@ describe("#files.get", () => {
   it("should succeed with status 200 ok when avatar is requested using key", async () => {
     const user = await buildUser();
     const key = path.join("avatars", user.id, uuidV4());
+    await buildAttachment({
+      key,
+      teamId: user.teamId,
+      userId: user.id,
+      contentType: "image/jpg",
+      acl: "public-read",
+    });
 
     ensureDirSync(
       path.dirname(path.join(env.FILE_STORAGE_LOCAL_ROOT_DIR, key))
@@ -274,7 +290,7 @@ describe("#files.get", () => {
 
     const res = await server.get(`/api/files.get?key=${key}`);
     expect(res.status).toEqual(200);
-    expect(res.headers.get("Content-Type")).toEqual("application/octet-stream");
+    expect(res.headers.get("Content-Type")).toEqual("image/jpg");
     expect(res.headers.get("Content-Disposition")).toEqual("attachment");
   });
 });

plugins/storage/server/api/files.ts

@@ -77,19 +77,20 @@ router.get(
     const { isPublicBucket, fileName } = AttachmentHelper.parseKey(key);
     const skipAuthorize = isPublicBucket || isSignedRequest;
     const cacheHeader = "max-age=604800, immutable";
-    let contentType =
+
+    const attachment = await Attachment.findOne({
+      where: { key },
+      rejectOnEmpty: true,
+    });
+    if (!skipAuthorize) {
+      authorize(actor, "read", attachment);
+    }
+
+    const contentType =
+      attachment.contentType ||
       (fileName ? mime.lookup(fileName) : undefined) ||
       "application/octet-stream";
 
-    if (!skipAuthorize) {
-      const attachment = await Attachment.findOne({
-        where: { key },
-        rejectOnEmpty: true,
-      });
-      authorize(actor, "read", attachment);
-      contentType = attachment.contentType;
-    }
-
     ctx.set("Accept-Ranges", "bytes");
     ctx.set("Cache-Control", cacheHeader);
     ctx.set("Content-Type", contentType);