mirror of
https://github.com/outline/outline.git
synced 2026-02-13 22:39:00 -06:00
e8bddbe104
* fix: probably copy-pasted function description * fix: userIdsMentioned was always empty * add: NotificationEventType.ResolveComment * move: split handler for "mentioned" vs. "resolved" The recipients for "resolved" will include more people (creator, repliers, mentioned), so it's easier to just split the handler than trying to augment it. * implement: handleResolvedComment * clone: CommentMentionedEmail as CommentResolvedEmail Changes coming up in next commit... * implement: CommentResolvedEmail * Fix "New Comment↓" incorrectly showing in Resolved ## Repro 1 (with production code) 1. In a list of long resolved comments, scroll up and select the first one. 2. From another account, resolve another comment. The hint appears. ## Repro 2 (with production code) 1. Select Most-Recent, then Resolved. 2. F5. It's scrolled all the way to the bottom. ## Repro 3 (after this PR) 1. Click on the notification when someone resolved a comment. The screen jumps to "Resolved" + showing hint unnecessarily. ## Fix The scrolling and hint was meant for Most Recent only, but missed out this case since "Resolve" is not part of the enum. * Better sentences * Refactor "mentions + author" calculation * Remove unnecessary check The resolver is already added to `userIdsNotified` from the start, so no point checking it again here.