From d1f282d4133e1850cc5a0db14f8fa910162bd190 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20Eduardo=20Jer=C3=A9z=20Gir=C3=B3n?= Date: Sat, 3 Aug 2024 21:06:40 -0600 Subject: [PATCH] Refactor help button implementation in InputControl and SelectControl components --- internal/view/web/component/help_button_modal.go | 16 ++-------------- internal/view/web/component/input_control.go | 1 - internal/view/web/component/select_control.go | 1 - 3 files changed, 2 insertions(+), 16 deletions(-) diff --git a/internal/view/web/component/help_button_modal.go b/internal/view/web/component/help_button_modal.go index 95542bd..48462f8 100644 --- a/internal/view/web/component/help_button_modal.go +++ b/internal/view/web/component/help_button_modal.go @@ -3,14 +3,12 @@ package component import ( lucide "github.com/eduardolat/gomponents-lucide" "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/components" "github.com/maragudk/gomponents/html" ) type HelpButtonModalParams struct { ModalTitle string ModalSize size - ButtonSize size Children []gomponents.Node } @@ -23,19 +21,9 @@ func HelpButtonModal(params HelpButtonModalParams) gomponents.Node { button := html.Button( mo.OpenerAttr, - components.Classes{ - "btn btn-neutral btn-ghost btn-circle": true, - "btn-sm": params.ButtonSize == SizeSm, - "btn-lg": params.ButtonSize == SizeLg, - }, + html.Class("btn btn-neutral btn-ghost btn-circle btn-sm"), html.Type("button"), - lucide.CircleHelp( - components.Classes{ - "size-4": params.ButtonSize == SizeSm, - "size-6": params.ButtonSize == SizeMd, - "size-8": params.ButtonSize == SizeLg, - }, - ), + lucide.CircleHelp(), ) return html.Div( diff --git a/internal/view/web/component/input_control.go b/internal/view/web/component/input_control.go index 021fe53..fde333e 100644 --- a/internal/view/web/component/input_control.go +++ b/internal/view/web/component/input_control.go @@ -52,7 +52,6 @@ func InputControl(params InputControlParams) gomponents.Node { len(params.HelpButtonChildren) > 0, HelpButtonModal(HelpButtonModalParams{ ModalTitle: params.Label, - ButtonSize: SizeSm, Children: params.HelpButtonChildren, }), ), diff --git a/internal/view/web/component/select_control.go b/internal/view/web/component/select_control.go index a731f7b..e85deee 100644 --- a/internal/view/web/component/select_control.go +++ b/internal/view/web/component/select_control.go @@ -47,7 +47,6 @@ func SelectControl(params SelectControlParams) gomponents.Node { len(params.HelpButtonChildren) > 0, HelpButtonModal(HelpButtonModalParams{ ModalTitle: params.Label, - ButtonSize: SizeSm, Children: params.HelpButtonChildren, }), ),