From 0e205ea28fa4a8f1a48a708339034e560bf22c38 Mon Sep 17 00:00:00 2001
From: Abhishek Shroff <shroff@kudosoft.net>
Date: Mon, 30 Sep 2024 11:26:29 +0530
Subject: [PATCH] [client] Await optimistic updates

---
 client/lib/libphylum/actions/action_resource_delete.dart | 8 ++++----
 client/lib/libphylum/actions/action_resource_mkdir.dart  | 8 ++++----
 client/lib/libphylum/actions/action_resource_move.dart   | 8 ++++----
 client/lib/libphylum/actions/action_resource_upload.dart | 8 ++++----
 4 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/client/lib/libphylum/actions/action_resource_delete.dart b/client/lib/libphylum/actions/action_resource_delete.dart
index 543c8793..0c747484 100644
--- a/client/lib/libphylum/actions/action_resource_delete.dart
+++ b/client/lib/libphylum/actions/action_resource_delete.dart
@@ -48,13 +48,13 @@ class ResourceDeleteAction extends PhylumAction with JsonApiAction {
   }
 
   @override
-  FutureOr<void> applyOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.updateResource(id, (o) => o(deleted: const Value(true)));
+  FutureOr applyOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.updateResource(id, (o) => o(deleted: const Value(true)));
   }
 
   @override
-  FutureOr<void> revertOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.updateResource(id, (o) => o(deleted: const Value(false)));
+  FutureOr revertOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.updateResource(id, (o) => o(deleted: const Value(false)));
   }
 
   @override
diff --git a/client/lib/libphylum/actions/action_resource_mkdir.dart b/client/lib/libphylum/actions/action_resource_mkdir.dart
index 77ecffb9..53a7bea7 100644
--- a/client/lib/libphylum/actions/action_resource_mkdir.dart
+++ b/client/lib/libphylum/actions/action_resource_mkdir.dart
@@ -49,13 +49,13 @@ class ResourceMkdirAction extends PhylumAction with JsonApiAction, ResourceCreat
   }
 
   @override
-  FutureOr<void> applyOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.createResource(resourceId, true, parent, resourceName, '');
+  FutureOr applyOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.createResource(resourceId, true, parent, resourceName, '');
   }
 
   @override
-  FutureOr<void> revertOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.deleteResource(resourceId);
+  FutureOr revertOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.deleteResource(resourceId);
   }
 
   @override
diff --git a/client/lib/libphylum/actions/action_resource_move.dart b/client/lib/libphylum/actions/action_resource_move.dart
index 5d7081fc..ec404801 100644
--- a/client/lib/libphylum/actions/action_resource_move.dart
+++ b/client/lib/libphylum/actions/action_resource_move.dart
@@ -72,8 +72,8 @@ class ResourceMoveAction extends PhylumAction with JsonApiAction {
   }
 
   @override
-  FutureOr<void> applyOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.updateResource(
+  FutureOr applyOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.updateResource(
       resourceId,
       (o) => o(
         name: Value.absentIfNull(resourceName),
@@ -83,8 +83,8 @@ class ResourceMoveAction extends PhylumAction with JsonApiAction {
   }
 
   @override
-  FutureOr<void> revertOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.updateResource(resourceId, (o) => o(parent: Value(oldParent)));
+  FutureOr revertOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.updateResource(resourceId, (o) => o(parent: Value(oldParent)));
   }
 
   @override
diff --git a/client/lib/libphylum/actions/action_resource_upload.dart b/client/lib/libphylum/actions/action_resource_upload.dart
index e8e38925..b536687f 100644
--- a/client/lib/libphylum/actions/action_resource_upload.dart
+++ b/client/lib/libphylum/actions/action_resource_upload.dart
@@ -74,13 +74,13 @@ class ResourceUploadAction extends PhylumAction with FileUploadApiAction, Resour
   }
 
   @override
-  FutureOr<void> applyOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.createResource(resourceId, false, parent, resourceName, contentType);
+  FutureOr applyOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.createResource(resourceId, false, parent, resourceName, contentType);
   }
 
   @override
-  FutureOr<void> revertOptimisticUpdate(PhylumAccount account) {
-    account.resourceRepository.deleteResource(resourceId);
+  FutureOr revertOptimisticUpdate(PhylumAccount account) {
+    return account.resourceRepository.deleteResource(resourceId);
   }
 
   @override