From 1cb16bf176eae8a1d2db7b95f9210fc9f13d18ba Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Mon, 25 Nov 2024 15:02:50 +0530 Subject: [PATCH] fix: email error handling on magic auth --- apiserver/plane/authentication/views/app/magic.py | 4 +--- apiserver/plane/authentication/views/space/magic.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/apiserver/plane/authentication/views/app/magic.py b/apiserver/plane/authentication/views/app/magic.py index e027843334..b3bf8c7776 100644 --- a/apiserver/plane/authentication/views/app/magic.py +++ b/apiserver/plane/authentication/views/app/magic.py @@ -44,10 +44,8 @@ class MagicGenerateEndpoint(APIView): return Response(exc.get_error_dict(), status=status.HTTP_400_BAD_REQUEST) origin = request.META.get("HTTP_ORIGIN", "/") - email = request.data.get("email", False) + email = request.data.get("email", "").strip().lower() try: - # Clean up the email - email = email.strip().lower() validate_email(email) adapter = MagicCodeProvider(request=request, key=email) key, token = adapter.initiate() diff --git a/apiserver/plane/authentication/views/space/magic.py b/apiserver/plane/authentication/views/space/magic.py index e763aaa07c..7c23d5fc34 100644 --- a/apiserver/plane/authentication/views/space/magic.py +++ b/apiserver/plane/authentication/views/space/magic.py @@ -39,10 +39,8 @@ class MagicGenerateSpaceEndpoint(APIView): return Response(exc.get_error_dict(), status=status.HTTP_400_BAD_REQUEST) origin = base_host(request=request, is_space=True) - email = request.data.get("email", False) + email = request.data.get("email", "").strip().lower() try: - # Clean up the email - email = email.strip().lower() validate_email(email) adapter = MagicCodeProvider(request=request, key=email) key, token = adapter.initiate()