Merge pull request #852 from pre-commit/install_only_once

Install multi-hook repositories only once

pre_commit/prefix.py

@@ -1,11 +1,11 @@
 from __future__ import unicode_literals
 
+import collections
 import os.path
 
 
-class Prefix(object):
-    def __init__(self, prefix_dir):
-        self.prefix_dir = prefix_dir
+class Prefix(collections.namedtuple('Prefix', ('prefix_dir',))):
+    __slots__ = ()
 
     def path(self, *parts):
         return os.path.normpath(os.path.join(self.prefix_dir, *parts))

pre_commit/repository.py

@@ -179,12 +179,12 @@ class Repository(object):
         return Prefix(self.store.clone(repo, rev, deps))
 
     def _venvs(self):
-        ret = []
+        ret = set()
         for _, hook in self.hooks:
             language = hook['language']
             version = hook['language_version']
-            deps = hook['additional_dependencies']
-            ret.append((
+            deps = tuple(hook['additional_dependencies'])
+            ret.add((
                 self._prefix_from_deps(language, deps),
                 language, version, deps,
             ))

tests/repository_test.py

@@ -466,7 +466,7 @@ def test_venvs(tempdir_factory, store):
     config = make_config_from_repo(path)
     repo = Repository.create(config, store)
     venv, = repo._venvs()
-    assert venv == (mock.ANY, 'python', python.get_default_version(), [])
+    assert venv == (mock.ANY, 'python', python.get_default_version(), ())
 
 
 def test_additional_dependencies(tempdir_factory, store):
@@ -474,8 +474,8 @@ def test_additional_dependencies(tempdir_factory, store):
     config = make_config_from_repo(path)
     config['hooks'][0]['additional_dependencies'] = ['pep8']
     repo = Repository.create(config, store)
-    venv, = repo._venvs()
-    assert venv == (mock.ANY, 'python', python.get_default_version(), ['pep8'])
+    env, = repo._venvs()
+    assert env == (mock.ANY, 'python', python.get_default_version(), ('pep8',))
 
 
 def test_additional_dependencies_roll_forward(tempdir_factory, store):