diff --git a/pre_commit/languages/golang.py b/pre_commit/languages/golang.py index f81b81ec..c0bfbcbc 100644 --- a/pre_commit/languages/golang.py +++ b/pre_commit/languages/golang.py @@ -9,6 +9,7 @@ from pre_commit.envcontext import Var from pre_commit.languages import helpers from pre_commit.util import clean_path_on_failure from pre_commit.util import cmd_output +from pre_commit.util import rmtree from pre_commit.xargs import xargs @@ -66,6 +67,9 @@ def install_environment( cmd_output('go', 'get', './...', cwd=repo_src_dir, env=env) for dependency in additional_dependencies: cmd_output('go', 'get', dependency, cwd=repo_src_dir, env=env) + # Same some disk space, we don't need these after installation + rmtree(repo_cmd_runner.path(directory, 'src')) + rmtree(repo_cmd_runner.path(directory, 'pkg')) def run_hook(repo_cmd_runner, hook, file_args): diff --git a/tests/repository_test.py b/tests/repository_test.py index 27da7a36..e913df73 100644 --- a/tests/repository_test.py +++ b/tests/repository_test.py @@ -553,13 +553,11 @@ def test_additional_golang_dependencies_installed( config['hooks'][0]['additional_dependencies'] = ['github.com/firba1/tpol'] repo = Repository.create(config, store) repo.require_installed() - with golang.in_env(repo.cmd_runner): - gopath = repo.cmd_runner.path(helpers.environment_dir( - golang.ENVIRONMENT_DIR, 'default', - )) - env = dict(os.environ, GOPATH=gopath) - output = cmd_output('go', 'list', '...', env=env)[1] - assert 'github.com/firba1/tpol' in output + binaries = os.listdir(repo.cmd_runner.path( + helpers.environment_dir(golang.ENVIRONMENT_DIR, 'default'), + 'bin', + )) + assert 'tpol' in binaries def test_reinstall(tempdir_factory, store, log_info_mock):