From a984a02c84b7ec3c27477777992e2e9a8fa91d8e Mon Sep 17 00:00:00 2001 From: Anthony Sottile Date: Tue, 17 Jun 2014 06:59:13 -0700 Subject: [PATCH] Make ordereddict a direct dependency. --- pre_commit/commands/autoupdate.py | 2 +- pre_commit/five.py | 9 ++++----- pre_commit/ordereddict.py | 7 +++++++ pre_commit/repository.py | 2 +- setup.py | 2 +- testing/fixtures.py | 2 +- tests/clientlib/validate_base_test.py | 2 +- tests/commands/autoupdate_test.py | 2 +- 8 files changed, 17 insertions(+), 11 deletions(-) create mode 100644 pre_commit/ordereddict.py diff --git a/pre_commit/commands/autoupdate.py b/pre_commit/commands/autoupdate.py index 5c6d1fe9..f9cce05c 100644 --- a/pre_commit/commands/autoupdate.py +++ b/pre_commit/commands/autoupdate.py @@ -3,7 +3,6 @@ from __future__ import unicode_literals import sys -from asottile.ordereddict import OrderedDict from asottile.yaml import ordered_dump from asottile.yaml import ordered_load from plumbum import local @@ -12,6 +11,7 @@ import pre_commit.constants as C from pre_commit.clientlib.validate_config import CONFIG_JSON_SCHEMA from pre_commit.clientlib.validate_config import load_config from pre_commit.jsonschema_extensions import remove_defaults +from pre_commit.ordereddict import OrderedDict from pre_commit.repository import Repository diff --git a/pre_commit/five.py b/pre_commit/five.py index ce7917d0..525a6de7 100644 --- a/pre_commit/five.py +++ b/pre_commit/five.py @@ -2,11 +2,10 @@ from __future__ import unicode_literals """five: six, redux""" # pylint:disable=invalid-name -PY2 = (str is bytes) -PY3 = (str is not bytes) +PY2 = str is bytes +PY3 = str is not bytes -# provide a symettrical `text` type to `bytes` -if PY2: +if PY2: # pragma: no cover (PY2 only) text = unicode # flake8: noqa -else: +else: # pragma: no cover (PY3 only) text = str diff --git a/pre_commit/ordereddict.py b/pre_commit/ordereddict.py new file mode 100644 index 00000000..2844cb46 --- /dev/null +++ b/pre_commit/ordereddict.py @@ -0,0 +1,7 @@ +from __future__ import absolute_import +from __future__ import unicode_literals + +try: + from collections import OrderedDict # noqa +except ImportError: # pragma: no cover (PY26) + from ordereddict import OrderedDict # noqa diff --git a/pre_commit/repository.py b/pre_commit/repository.py index 4e2ee42b..1bc951a6 100644 --- a/pre_commit/repository.py +++ b/pre_commit/repository.py @@ -1,10 +1,10 @@ from __future__ import unicode_literals -from asottile.ordereddict import OrderedDict from cached_property import cached_property from pre_commit.languages.all import languages from pre_commit.manifest import Manifest +from pre_commit.ordereddict import OrderedDict from pre_commit.prefixed_command_runner import PrefixedCommandRunner diff --git a/setup.py b/setup.py index a1504f8a..33c321b0 100644 --- a/setup.py +++ b/setup.py @@ -32,11 +32,11 @@ setup( }, install_requires=[ 'argparse', - 'asottile.ordereddict', 'asottile.yaml', 'cached-property', 'jsonschema', 'nodeenv>=0.9.4', + 'ordereddict', 'plumbum', 'pyyaml', 'simplejson', diff --git a/testing/fixtures.py b/testing/fixtures.py index 3bf18273..b3af9910 100644 --- a/testing/fixtures.py +++ b/testing/fixtures.py @@ -3,7 +3,6 @@ from __future__ import unicode_literals import io import os.path -from asottile.ordereddict import OrderedDict from asottile.yaml import ordered_dump from plumbum import local @@ -12,6 +11,7 @@ from pre_commit.clientlib.validate_manifest import load_manifest from pre_commit.clientlib.validate_config import CONFIG_JSON_SCHEMA from pre_commit.clientlib.validate_config import validate_config_extra from pre_commit.jsonschema_extensions import apply_defaults +from pre_commit.ordereddict import OrderedDict from testing.util import copy_tree_to_path from testing.util import get_head_sha from testing.util import get_resource_path diff --git a/tests/clientlib/validate_base_test.py b/tests/clientlib/validate_base_test.py index 9b40e8c0..e10048d9 100644 --- a/tests/clientlib/validate_base_test.py +++ b/tests/clientlib/validate_base_test.py @@ -1,10 +1,10 @@ from __future__ import unicode_literals import pytest -from asottile.ordereddict import OrderedDict from asottile.yaml import ordered_load from pre_commit.clientlib.validate_base import get_validator +from pre_commit.ordereddict import OrderedDict from testing.util import get_resource_path diff --git a/tests/commands/autoupdate_test.py b/tests/commands/autoupdate_test.py index 50ce031d..b011ac28 100644 --- a/tests/commands/autoupdate_test.py +++ b/tests/commands/autoupdate_test.py @@ -2,13 +2,13 @@ from __future__ import unicode_literals import pytest import shutil -from asottile.ordereddict import OrderedDict from plumbum import local import pre_commit.constants as C from pre_commit.commands.autoupdate import _update_repository from pre_commit.commands.autoupdate import autoupdate from pre_commit.commands.autoupdate import RepositoryCannotBeUpdatedError +from pre_commit.ordereddict import OrderedDict from pre_commit.runner import Runner from testing.auto_namedtuple import auto_namedtuple from testing.fixtures import make_config_from_repo