diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9cd63760..11f0ac29 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -27,5 +27,5 @@ repos: - id: add-trailing-comma - repo: meta hooks: + - id: check-hooks-apply - id: check-useless-excludes - - id: check-files-matches-any diff --git a/pre_commit/meta_hooks/check_files_matches_any.py b/pre_commit/meta_hooks/check_hooks_apply.py similarity index 100% rename from pre_commit/meta_hooks/check_files_matches_any.py rename to pre_commit/meta_hooks/check_hooks_apply.py diff --git a/pre_commit/repository.py b/pre_commit/repository.py index 2eb62ecb..bc0ecad3 100644 --- a/pre_commit/repository.py +++ b/pre_commit/repository.py @@ -255,7 +255,7 @@ class MetaRepository(LocalRepository): @cached_property def manifest_hooks(self): # The hooks are imported here to prevent circular imports. - from pre_commit.meta_hooks import check_files_matches_any + from pre_commit.meta_hooks import check_hooks_apply from pre_commit.meta_hooks import check_useless_excludes def _make_entry(mod): @@ -267,11 +267,11 @@ class MetaRepository(LocalRepository): meta_hooks = [ { - 'id': 'check-files-matches-any', - 'name': 'Check hooks match any files', + 'id': 'check-hooks-apply', + 'name': 'Check hooks apply to the repository', 'files': '.pre-commit-config.yaml', 'language': 'system', - 'entry': _make_entry(check_files_matches_any), + 'entry': _make_entry(check_hooks_apply), }, { 'id': 'check-useless-excludes', diff --git a/tests/meta_hooks/hook_matches_any_test.py b/tests/meta_hooks/check_hooks_apply_test.py similarity index 90% rename from tests/meta_hooks/hook_matches_any_test.py rename to tests/meta_hooks/check_hooks_apply_test.py index 005cdf68..0ca68802 100644 --- a/tests/meta_hooks/hook_matches_any_test.py +++ b/tests/meta_hooks/check_hooks_apply_test.py @@ -1,6 +1,6 @@ from collections import OrderedDict -from pre_commit.meta_hooks import check_files_matches_any +from pre_commit.meta_hooks import check_hooks_apply from pre_commit.util import cwd from testing.fixtures import add_config_to_repo from testing.fixtures import git_dir @@ -25,7 +25,7 @@ def test_hook_excludes_everything( add_config_to_repo(repo, config) with cwd(repo): - assert check_files_matches_any.main(()) == 1 + assert check_hooks_apply.main(()) == 1 out, _ = capsys.readouterr() assert 'check-useless-excludes does not apply to this repository' in out @@ -50,7 +50,7 @@ def test_hook_includes_nothing( add_config_to_repo(repo, config) with cwd(repo): - assert check_files_matches_any.main(()) == 1 + assert check_hooks_apply.main(()) == 1 out, _ = capsys.readouterr() assert 'check-useless-excludes does not apply to this repository' in out @@ -75,7 +75,7 @@ def test_hook_types_not_matched( add_config_to_repo(repo, config) with cwd(repo): - assert check_files_matches_any.main(()) == 1 + assert check_hooks_apply.main(()) == 1 out, _ = capsys.readouterr() assert 'check-useless-excludes does not apply to this repository' in out @@ -100,7 +100,7 @@ def test_hook_types_excludes_everything( add_config_to_repo(repo, config) with cwd(repo): - assert check_files_matches_any.main(()) == 1 + assert check_hooks_apply.main(()) == 1 out, _ = capsys.readouterr() assert 'check-useless-excludes does not apply to this repository' in out @@ -124,7 +124,7 @@ def test_valid_includes( add_config_to_repo(repo, config) with cwd(repo): - assert check_files_matches_any.main(()) == 0 + assert check_hooks_apply.main(()) == 0 out, _ = capsys.readouterr() assert out == ''