Commit Graph

853 Commits

Author SHA1 Message Date
Anthony Sottile
89ab609732 fix the default value for types_or 2020-11-25 18:21:37 -08:00
Anthony Sottile
7486dee082 fix for base executable with non-ascii characters on windows 2020-11-25 12:44:48 -08:00
Paul Fischer
610716d3d1 added warning if globs are used instead of regex 2020-11-22 18:53:48 -08:00
Paul Fischer
53109a0127 fixed message if repo couldn't be updated due to missing hook(s) 2020-11-22 13:34:10 -08:00
Michael Vincent
120d60223a Improve performance by ignoring submodules
When git status runs in a repo with submodules, it'll recursively run
git status in every submodule as well by default (sequentially).
git status is substantially slower on Windows than on Linux. git diff
behaves similarly to git status in terms of running recursively within
all submodules. In repos with hundreds of submodules, this quickly adds
up when git status/diff are called multiple times. Pre-commit runs
git status once at the beginning of an operation and then runs git diff
before and after each hook. These calls quickly add up and make
pre-commit unusable in large repos with lots of submodules.

This commit drastically improves performance in repos with lots of
submodules and fixes #1701 by telling git status and git diff to ignore
submodules. This change is not expected to have any negative effect on
existing hooks because each submodule should manage its own hooks
instead of relying on superproject hooks to manipulate their contents.
2020-11-19 23:26:05 -06:00
Anthony Sottile
a3e3b3d8aa fix for rbenv used outside of pre-commit and language_version: default 2020-11-17 11:58:46 -08:00
Anthony Sottile
8d28c9ab40 Merge pull request #1691 from pre-commit/slightly_simpler_enum
use slightly simpler enum syntax
2020-11-09 13:24:05 -08:00
Anthony Sottile
55cdfc6fd2 use slightly simpler enum syntax 2020-11-09 12:29:57 -08:00
Anthony Sottile
1494faee1f Merge pull request #1687 from pre-commit/simple_rev_line_re
remove DOTALL on REV_LINE_RE
2020-11-06 16:32:46 -08:00
Anthony Sottile
64d57ba466 remove DOTALL on REV_LINE_RE 2020-11-06 14:36:43 -08:00
Anthony Sottile
14f984fbcf improve xargs when running windows batch files 2020-11-06 13:09:01 -08:00
Anthony Sottile
c972205214 Merge pull request #1684 from pre-commit/migrate_config_less_work
only perform migrate_config parsing if it is a list
2020-11-05 16:27:23 -08:00
Anthony Sottile
1975c056bc Merge pull request #1683 from pre-commit/textwrap_indent
use textwrap.indent instead of _indent
2020-11-05 16:22:17 -08:00
Anthony Sottile
b4ab84df58 only perform migrate_config parsing if it is a list 2020-11-05 16:05:41 -08:00
Anthony Sottile
64876697b5 use textwrap.indent instead of _indent 2020-11-05 15:59:46 -08:00
Ruairidh MacLeod
aa8023407e fix dotnet build cleanup 2020-11-03 08:53:17 -08:00
Marco Gorelli
62f668fc3f add types_or 2020-11-02 17:25:10 +00:00
Anthony Sottile
e05ac1e91f don't call ruby install for language_version = default 2020-10-29 19:45:06 -07:00
Anthony Sottile
62b8d0ed82 allow default language_version of system when homedir is / 2020-10-28 22:56:10 -07:00
Anthony Sottile
7f9f66e542 don't use system for ruby/node if it is a shim exe 2020-10-28 16:52:55 -07:00
Anthony Sottile
29f3e67655 improve node install by using npm pack 2020-10-28 15:13:53 -07:00
Anthony Sottile
24dfeed89c Replace EnvironT with MutableMapping[str, str] 2020-10-28 13:00:25 -07:00
int3l
47e758d8f1 Distinct error handling exit codes
https://tldp.org/LDP/abs/html/exitcodes.html - exit codes convention
2020-10-28 11:13:04 -07:00
Joseph Moniz
70ab1c3b6f add coursier (jvm) as a language 2020-10-27 09:21:54 -07:00
Marco Gorelli
a0658c06bf add --negate flag to pygrep 2020-10-17 18:50:40 +01:00
Anthony Sottile
3584b99caa simplify docker run 2020-10-10 18:09:51 -07:00
Anthony Sottile
202f0bbbc9 Merge pull request #1598 from rkm/feature/dotnet
add initial dotnet support
2020-09-27 15:25:56 -07:00
Ruairidh MacLeod
003e4c21e0 add initial dotnet support 2020-09-27 15:04:35 -07:00
Maximilian Cosmo Sitter
3de3c6a5fc Update pre-commit version in sample config 2020-09-27 14:54:42 -07:00
Anthony Sottile
58a190fd69 don't pass through -p if using the default version 2020-09-23 17:44:18 -07:00
Thomas Romera
36653586a0 update rbenv / ruby-build 2020-09-22 23:03:01 -07:00
Anthony Sottile
365f896c36 fix a few spelling errors
found via `pre-commit  try-repo https://github.com/codespell-project/codespell --all-files`
2020-09-20 19:21:24 -07:00
Anthony Sottile
91530f1005 check cygwin mismatch earlier 2020-09-20 10:42:11 -07:00
Anthony Sottile
3e2b9dc91a Merge pull request #1603 from pre-commit/no_format_executable
Fix ruby hooks when --format-executable is in gemrc
2020-09-18 09:37:41 -07:00
Anthony Sottile
13eed4ac5b Fix ruby hooks when --format-executable is in gemrc
I used this gemrc to break things (default on opensuse):

```yaml
---
:benchmark: false
:install: --format-executable --no-user-install
install: --format-executable --no-user-install
:backtrace: true
:update_sources: true
:format_executable: true
:verbose: true
:update: --format-executable --no-user-install
update: --format-executable --no-user-install
:bulk_threshold: 1000
:sources:
- https://rubygems.org
```
2020-09-18 09:13:19 -07:00
Anthony Sottile
4888644990 remove hardcoded python location 2020-09-15 12:04:25 -07:00
Celeborn2BeAlive
273326b89b drop python.exe extension on windows on shebang 2020-09-09 12:42:48 -07:00
Anthony Sottile
3a0406847b fix excess whitespace in traceback in error 2020-09-07 15:01:50 -07:00
Anthony Sottile
b149c7a344 fix for node healthy() when system executable moves 2020-09-07 13:23:02 -07:00
Anthony Sottile
7c804cabe6 Merge pull request #1577 from pre-commit/os_replace
fix atomic file replace on windows
2020-08-23 10:49:14 -07:00
Anthony Sottile
79b098c409 fix atomic file replace on windows 2020-08-23 10:18:59 -07:00
Anthony Sottile
b63b37ac36 fix cache of invalidated unhealthy environment version info 2020-08-23 10:17:24 -07:00
Ruairidh MacLeod
eb8b48aeb4 remove docker_is_running check from source
Moved to testing.util so it can be used for the skipif_cant_run_docker
test hooks.
2020-08-22 17:33:32 -07:00
Anthony Sottile
a438dbfcf6 Merge pull request #1570 from pre-commit/readonly
allow pre-commit to succeed on a readonly store directory
2020-08-22 11:19:11 -07:00
Anthony Sottile
bf33f4c91c allow pre-commit to succeed on a readonly store directory 2020-08-22 10:51:57 -07:00
Johan Henkens
4063730925 Save diff between hook executions 2020-08-21 20:41:06 -07:00
Anthony Sottile
4f5cb99ff5 Merge pull request #1544 from pre-commit/wip_warning_on_old_config_style
warn on old list-style configuration
2020-07-25 14:27:08 -07:00
Anthony Sottile
e384c182bc Merge pull request #1546 from pre-commit/error_logging_read_only_filesystem
better error handling when Store is readonly
2020-07-25 13:10:39 -07:00
Anthony Sottile
68510596d3 warn on old list-style configuration 2020-07-25 13:04:54 -07:00
Anthony Sottile
cee834bb5e better error handling when Store is readonly 2020-07-25 12:32:54 -07:00