mirror of
https://github.com/pre-commit/pre-commit.git
synced 2026-01-14 13:00:10 -06:00
b1389603e0
Before there was a `getcwd` syscall for every filename which was filtered. Instead this is now cached per-run. - When all files are identified by filename only: ~45% improvement - When no files are identified by filename only: ~55% improvement This makes little difference to overall execution, the bigger win is eliminating the `memoize_by_cwd` hack. Just removing the memoization would have *increased* the runtime by 300-500%.
70 lines
2.1 KiB
Python
70 lines
2.1 KiB
Python
from __future__ import print_function
|
|
|
|
import argparse
|
|
import re
|
|
|
|
from cfgv import apply_defaults
|
|
|
|
import pre_commit.constants as C
|
|
from pre_commit import git
|
|
from pre_commit.clientlib import load_config
|
|
from pre_commit.clientlib import MANIFEST_HOOK_DICT
|
|
from pre_commit.commands.run import Classifier
|
|
|
|
|
|
def exclude_matches_any(filenames, include, exclude):
|
|
if exclude == '^$':
|
|
return True
|
|
include_re, exclude_re = re.compile(include), re.compile(exclude)
|
|
for filename in filenames:
|
|
if include_re.search(filename) and exclude_re.search(filename):
|
|
return True
|
|
return False
|
|
|
|
|
|
def check_useless_excludes(config_file):
|
|
config = load_config(config_file)
|
|
classifier = Classifier(git.get_all_files())
|
|
retv = 0
|
|
|
|
exclude = config['exclude']
|
|
if not exclude_matches_any(classifier.filenames, '', exclude):
|
|
print(
|
|
'The global exclude pattern {!r} does not match any files'
|
|
.format(exclude),
|
|
)
|
|
retv = 1
|
|
|
|
for repo in config['repos']:
|
|
for hook in repo['hooks']:
|
|
# Not actually a manifest dict, but this more accurately reflects
|
|
# the defaults applied during runtime
|
|
hook = apply_defaults(hook, MANIFEST_HOOK_DICT)
|
|
names = classifier.filenames
|
|
types, exclude_types = hook['types'], hook['exclude_types']
|
|
names = classifier.by_types(names, types, exclude_types)
|
|
include, exclude = hook['files'], hook['exclude']
|
|
if not exclude_matches_any(names, include, exclude):
|
|
print(
|
|
'The exclude pattern {!r} for {} does not match any files'
|
|
.format(exclude, hook['id']),
|
|
)
|
|
retv = 1
|
|
|
|
return retv
|
|
|
|
|
|
def main(argv=None):
|
|
parser = argparse.ArgumentParser()
|
|
parser.add_argument('filenames', nargs='*', default=[C.CONFIG_FILE])
|
|
args = parser.parse_args(argv)
|
|
|
|
retv = 0
|
|
for filename in args.filenames:
|
|
retv |= check_useless_excludes(filename)
|
|
return retv
|
|
|
|
|
|
if __name__ == '__main__':
|
|
exit(main())
|