From 87f2fbf36be3eb6bc1242d08cdcc5b805b090589 Mon Sep 17 00:00:00 2001
From: KernelDeimos <7225168+KernelDeimos@users.noreply.github.com>
Date: Tue, 30 Sep 2025 13:02:21 -0400
Subject: [PATCH] clean: DriverService

Removes dead code and reduces branching. In the get_service_or_throw_
method, the changes in this commit show how the branching got more
redundnat in the previous change.
---
 .../src/services/drivers/DriverService.js     | 73 ++++++++-----------
 1 file changed, 30 insertions(+), 43 deletions(-)

diff --git a/src/backend/src/services/drivers/DriverService.js b/src/backend/src/services/drivers/DriverService.js
index c9be4cad..c0e70405 100644
--- a/src/backend/src/services/drivers/DriverService.js
+++ b/src/backend/src/services/drivers/DriverService.js
@@ -206,8 +206,8 @@ class DriverService extends BaseService {
                     description: 'get usage information for drivers',
                     parameters: {},
                     result: { type: 'json' },
-                }
-            }
+                },
+            },
         });
     }
     
@@ -237,13 +237,6 @@ class DriverService extends BaseService {
         if (this.interface_to_implementation.hasOwnProperty(interface_name)) {
             return this.interface_to_implementation[interface_name];
         }
-        
-        return;
-        this.log.noticeme('HERE IT IS');
-        const options = this.services.get_implementors(interface_name);
-        this.log.info('test', { options });
-        if ( options.length < 1 ) return;
-        return options[0];
     }
 
 
@@ -304,7 +297,7 @@ class DriverService extends BaseService {
             'puter-apps': 'es:app',
             'puter-subdomains': 'es:subdomain',
             'puter-notifications': 'es:notification',
-        }
+        };
         
         driver = driver ?? iface_to_driver[iface] ?? iface;
         
@@ -314,7 +307,7 @@ class DriverService extends BaseService {
             'puter-apps': 'crud-q',
             'puter-subdomains': 'crud-q',
             'puter-notifications': 'crud-q',
-        }
+        };
         iface = iface_to_iface[iface] ?? iface;
 
         let skip_usage = false;
@@ -478,11 +471,9 @@ class DriverService extends BaseService {
             service_name,
             iface,
             method,
-            policy: effective_policy
+            policy: effective_policy,
         });
             
-        const method_key = `V1:${service_name}:${iface}:${method}`;
-            
         const invoker = Invoker.create({
             decorators: [
                 {
@@ -650,38 +641,34 @@ class DriverService extends BaseService {
         
         if ( driver_service_exists ) {
             return this.services.get(name);
-        } else {
-            const svc_registry = this.services.get('registry');
-            const col_drivers = svc_registry.get('drivers');
-            let maybe_driver = col_drivers.get(`${iface}:${name}`);
-            if ( maybe_driver ) {
-                const org = maybe_driver;
-                const impl = Object.create(org);
-                
-                // TraitsFeature also uses `in <impl>`, so this should cover
-                // all the methods that would get re-"`bind`'d"
-                for ( const k in org ) {
-                    if ( ! (typeof org[k] === 'function') ) continue;
-                    impl[k] = org[k].bind(org);
-                }
-                maybe_driver = class extends AdvancedBase {
-                    static IMPLEMENTS = {
-                        [iface]: impl,
-                    };
-                };
-                Object.defineProperty(maybe_driver, 'name', {
-                    value: `driver:${iface}:${name}`,
-                });
-                return new maybe_driver();
+        }
+
+        const svc_registry = this.services.get('registry');
+        const col_drivers = svc_registry.get('drivers');
+        let maybe_driver = col_drivers.get(`${iface}:${name}`);
+        if ( maybe_driver ) {
+            const org = maybe_driver;
+            const impl = Object.create(org);
+            
+            // TraitsFeature also uses `in <impl>`, so this should cover
+            // all the methods that would get re-"`bind`'d"
+            for ( const k in org ) {
+                if ( ! (typeof org[k] === 'function') ) continue;
+                impl[k] = org[k].bind(org);
             }
+            maybe_driver = class extends AdvancedBase {
+                static IMPLEMENTS = {
+                    [iface]: impl,
+                };
+            };
+            Object.defineProperty(maybe_driver, 'name', {
+                value: `driver:${iface}:${name}`,
+            });
+            return new maybe_driver();
         }
 
-        if ( ! driver_service_exists ) {
-            const svc_apiError = this.services.get('api-error');
-            throw svc_apiError.create('no_implementation_available', { iface });
-        }
-
-        return this.services.get(name);
+        const svc_apiError = this.services.get('api-error');
+        throw svc_apiError.create('no_implementation_available', { iface });
     }
 }