From a64a786528da47a90be0b1d92e455180c6485751 Mon Sep 17 00:00:00 2001
From: KernelDeimos <7225168+KernelDeimos@users.noreply.github.com>
Date: Thu, 9 Oct 2025 19:13:51 -0400
Subject: [PATCH] devex: misc log cleanup

---
 .../modules/puterfs/DatabaseFSEntryService.js    |  2 +-
 .../src/modules/puterfs/ResourceService.js       |  4 ++--
 src/backend/src/om/definitions/PropType.js       |  4 +++-
 src/backend/src/routers/login.js                 | 16 +++++++++-------
 src/backend/src/services/auth/ACLService.js      |  2 +-
 src/backend/src/services/auth/AuthService.js     |  4 ++--
 6 files changed, 18 insertions(+), 14 deletions(-)

diff --git a/src/backend/src/modules/puterfs/DatabaseFSEntryService.js b/src/backend/src/modules/puterfs/DatabaseFSEntryService.js
index f1f4f13e..e4dc3bec 100644
--- a/src/backend/src/modules/puterfs/DatabaseFSEntryService.js
+++ b/src/backend/src/modules/puterfs/DatabaseFSEntryService.js
@@ -457,7 +457,7 @@ class DatabaseFSEntryService extends BaseService {
 
         const queue = this.currentState.queue;
 
-        this.log.info(
+        this.log.debug(
             `Executing ${queue.length} operations...`
         );
 
diff --git a/src/backend/src/modules/puterfs/ResourceService.js b/src/backend/src/modules/puterfs/ResourceService.js
index 99774a62..307ef352 100644
--- a/src/backend/src/modules/puterfs/ResourceService.js
+++ b/src/backend/src/modules/puterfs/ResourceService.js
@@ -62,7 +62,7 @@ class ResourceService extends BaseService {
             };
         });
         entry.onFree = entry.freePromise.then.bind(entry.freePromise);
-        this.log.info(`registering resource`, { uid: entry.uid });
+        this.log.debug(`registering resource`, { uid: entry.uid });
         this.uidToEntry[entry.uid] = entry;
         if ( entry.path ) {
             this.uidToPath[entry.uid] = entry.path;
@@ -72,7 +72,7 @@ class ResourceService extends BaseService {
     }
 
     free (uid) {
-        this.log.info(`freeing`, { uid });
+        this.log.debug(`freeing`, { uid });
         const entry = this.uidToEntry[uid];
         if ( ! entry ) return;
         delete this.uidToEntry[uid];
diff --git a/src/backend/src/om/definitions/PropType.js b/src/backend/src/om/definitions/PropType.js
index 4ecdedbb..fc75ffdc 100644
--- a/src/backend/src/om/definitions/PropType.js
+++ b/src/backend/src/om/definitions/PropType.js
@@ -113,7 +113,9 @@ class PropType extends AdvancedBase {
             this.chains.factory && [...this.chains.factory].reverse()
         ) || [];
 
-        console.log('FACTORIES', factories)
+        if ( process.env.DEBUG ) {
+            console.log('FACTORIES', factories);
+        }
 
         for ( const factory of factories ) {
             const result = await factory(extra);
diff --git a/src/backend/src/routers/login.js b/src/backend/src/routers/login.js
index 174cb068..66feac82 100644
--- a/src/backend/src/routers/login.js
+++ b/src/backend/src/routers/login.js
@@ -59,13 +59,15 @@ const complete_ = async ({ req, res, user }) => {
 router.post('/login', express.json(), body_parser_error_handler, 
     // Add diagnostic middleware to log captcha data
     (req, res, next) => {
-        console.log('====== LOGIN CAPTCHA DIAGNOSTIC ======');
-        console.log('LOGIN REQUEST RECEIVED with captcha data:', {
-            hasCaptchaToken: !!req.body.captchaToken,
-            hasCaptchaAnswer: !!req.body.captchaAnswer,
-            captchaToken: req.body.captchaToken ? req.body.captchaToken.substring(0, 8) + '...' : undefined,
-            captchaAnswer: req.body.captchaAnswer
-        });
+        if ( process.env.DEBUG ) {
+            console.log('====== LOGIN CAPTCHA DIAGNOSTIC ======');
+            console.log('LOGIN REQUEST RECEIVED with captcha data:', {
+                hasCaptchaToken: !!req.body.captchaToken,
+                hasCaptchaAnswer: !!req.body.captchaAnswer,
+                captchaToken: req.body.captchaToken ? req.body.captchaToken.substring(0, 8) + '...' : undefined,
+                captchaAnswer: req.body.captchaAnswer
+            });
+        }
         next();
     },
     requireCaptcha({ strictMode: true, eventType: 'login' }), 
diff --git a/src/backend/src/services/auth/ACLService.js b/src/backend/src/services/auth/ACLService.js
index 38041ad8..be091f4e 100644
--- a/src/backend/src/services/auth/ACLService.js
+++ b/src/backend/src/services/auth/ACLService.js
@@ -438,7 +438,7 @@ class ACLService extends BaseService {
                     await appdata_node.is_above(fsNode)
                 )
             ) {
-                console.log('TRUE BECAUSE APPDATA');
+                this.log.debug('TRUE BECAUSE APPDATA');
                 return true;
             }
         }
diff --git a/src/backend/src/services/auth/AuthService.js b/src/backend/src/services/auth/AuthService.js
index e7beb864..b65e47bf 100644
--- a/src/backend/src/services/auth/AuthService.js
+++ b/src/backend/src/services/auth/AuthService.js
@@ -209,7 +209,7 @@ class AuthService extends BaseService {
             throw APIError.create('forbidden');
         }
 
-        this.log.info(`generating user-app token for app ${app_uid} and user ${actor_type.user.uuid}`, {
+        this.log.debug(`generating user-app token for app ${app_uid} and user ${actor_type.user.uuid}`, {
             app_uid,
             user_uid: actor_type.user.uuid,
         })
@@ -251,7 +251,7 @@ class AuthService extends BaseService {
      * session's metadata.
      */
     async create_session_ (user, meta = {}) {
-        this.log.info(`CREATING SESSION`);
+        this.log.debug(`CREATING SESSION`);
 
         if ( meta.req ) {
             const req = meta.req;