From d7aa08b345241dbbaa9ecf02812a605e5a90028c Mon Sep 17 00:00:00 2001 From: jelveh Date: Fri, 27 Dec 2024 17:53:43 -0800 Subject: [PATCH] Revert "if clichouse exists hit it in `_refresh_app_stats`" This reverts commit 9867d264328fd03e6a004c144b7ac93ce8e4555b. --- .../src/services/AppInformationService.js | 38 ++++--------------- 1 file changed, 8 insertions(+), 30 deletions(-) diff --git a/src/backend/src/services/AppInformationService.js b/src/backend/src/services/AppInformationService.js index 477e570b..ecc67e53 100644 --- a/src/backend/src/services/AppInformationService.js +++ b/src/backend/src/services/AppInformationService.js @@ -384,40 +384,18 @@ class AppInformationService { const apps = await db.read(`SELECT uid FROM apps`); for ( const app of apps ) { - // open count const key_open_count = `apps:open_count:uid:${app.uid}`; - let open_count; - - if(global.clickhouseClient) { - const result = await global.clickhouseClient.query({ - query: `SELECT COUNT(_id) AS open_count FROM app_opens WHERE app_uid = '${app_uid}'`, - format: 'JSONEachRow' - }); - const rows = await result.json(); - open_count = rows[0]?.open_count ?? 0; - }else{ - open_count = (await db.read( - `SELECT COUNT(_id) AS open_count FROM app_opens WHERE app_uid = ?`, - [app_uid] - ))[0].open_count; - } + const { open_count } = (await db.read( + `SELECT COUNT(_id) AS open_count FROM app_opens WHERE app_uid = ?`, + [app.uid] + ))[0]; kv.set(key_open_count, open_count); - // user count const key_user_count = `apps:user_count:uid:${app.uid}`; - let user_count; - - if(global.clickhouseClient) { - const result = await global.clickhouseClient.query({ - query: `SELECT COUNT(DISTINCT user_id) AS uniqueUsers FROM app_opens WHERE app_uid = '${app_uid}'`, - format: 'JSONEachRow' - }); - const rows = await result.json(); - user_count = rows[0]?.uniqueUsers ?? 0; - }else{ - user_count = (await db.read(`SELECT COUNT(DISTINCT user_id) AS user_count FROM app_opens WHERE app_uid = ?`, [app_uid]))[0].user_count; - } - + const { user_count } = (await db.read( + `SELECT COUNT(DISTINCT user_id) AS user_count FROM app_opens WHERE app_uid = ?`, + [app.uid] + ))[0]; kv.set(key_user_count, user_count); } }