From dc6a931a237463c7cb6b1c8d1798f4a77d610a84 Mon Sep 17 00:00:00 2001 From: KernelDeimos <7225168+KernelDeimos@users.noreply.github.com> Date: Thu, 16 Oct 2025 17:12:33 -0400 Subject: [PATCH] fix: error logs are too verbose There were some extra logs when an error triggers an alarm that don't need to be there. --- src/backend/src/modules/core/AlarmService.js | 4 +++- src/backend/src/modules/core/ErrorService.js | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/backend/src/modules/core/AlarmService.js b/src/backend/src/modules/core/AlarmService.js index 59111a8d..d8735055 100644 --- a/src/backend/src/modules/core/AlarmService.js +++ b/src/backend/src/modules/core/AlarmService.js @@ -112,7 +112,9 @@ class AlarmService extends BaseService { * @param {object} fields - Additional information about the alarm. */ create (id, message, fields) { - this.log.error(`upcoming alarm: ${id}: ${message}`); + if ( this.config.log_upcoming_alarms ) { + this.log.error(`upcoming alarm: ${id}: ${message}`); + } let existing = false; /** * Method to create an alarm with the given ID, message, and fields. diff --git a/src/backend/src/modules/core/ErrorService.js b/src/backend/src/modules/core/ErrorService.js index 041ed2a3..c5ed96bc 100644 --- a/src/backend/src/modules/core/ErrorService.js +++ b/src/backend/src/modules/core/ErrorService.js @@ -92,9 +92,6 @@ class ErrorService extends BaseService { message = message ?? source?.message; logger = logger ?? this.backupLogger; logger.error(`Error @ ${location}: ${message}; ` + source?.stack); - if ( trace ) { - logger.error(source); - } if ( alarm ) { const alarm_id = `${location}:${message}`;