From 90bf1cf6012070f510372cabcaa51a7ab6980fe2 Mon Sep 17 00:00:00 2001 From: Lawrence MacGuire Date: Thu, 28 Nov 2013 20:21:14 +0800 Subject: [PATCH 1/2] Slight semantic fix for "I do not have any public repos" In the "GitHub Profile" section, it will display "$user is a developer with X public repositories. ..." However, if the user in question only has other people's forks, it will display "I have no public repositories". Two conflicting statements. The section now states "All my repositories are forks" if that's the case. --- js/githubresume.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/js/githubresume.js b/js/githubresume.js index 73fec72..3c6c0f9 100644 --- a/js/githubresume.js +++ b/js/githubresume.js @@ -372,7 +372,11 @@ var run = function() { ++itemCount; }); } else { - $('#jobs').html('').append('

I do not have any public repositories. Sorry.

'); + if(data.length > 0){ + $('#jobs').html('').append('

All my repositories are forks. Sorry.

'); + } else { + $('#jobs').html('').append('

I do not have any public repositories. Sorry.

'); + } } } }); From c7b7c2e2cf6511d69bb23fac5e4f8fad657a0fd2 Mon Sep 17 00:00:00 2001 From: Lawrence MacGuire Date: Thu, 28 Nov 2013 23:19:56 +0800 Subject: [PATCH 2/2] Fixing 1st vs 3rd person texts --- js/githubresume.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/githubresume.js b/js/githubresume.js index 3c6c0f9..56a0f51 100644 --- a/js/githubresume.js +++ b/js/githubresume.js @@ -373,9 +373,9 @@ var run = function() { }); } else { if(data.length > 0){ - $('#jobs').html('').append('

All my repositories are forks. Sorry.

'); + $('#jobs').html('').append('

All of this user\'s repositories seem to be forks. Sorry.

'); } else { - $('#jobs').html('').append('

I do not have any public repositories. Sorry.

'); + $('#jobs').html('').append('

Unfortunately, this user does not seem to have any public repositories.

'); } } }