Files
routedns/failrotate.go
Frank Olbricht 7c57527523 Failback immediately if reset-after is set to 0 and new flag to fail on empty responses (#448)
* Failback immediately

* Add `empty-error` for detecting unusual empty responses

* Treat all empty responses as errors

* Multiple CNAMES + No records

* folbricht's suggestions

* Clarify `0` seconds

* Suggestion for single-request failover

* update

* Check for EDE when deciding on 'empty-error'

* fix failback

---------

Co-authored-by: Anuskuss <anuskuss@googlemail.com>
2025-05-04 13:45:01 +02:00

126 lines
3.6 KiB
Go

package rdns
import (
"sync"
"log/slog"
"github.com/miekg/dns"
)
// FailRotate is a resolver group that queries the same resolver unless that
// returns a failure in which case the request is retried on the next one for
// up to N times (with N the number of resolvers in the group). If the last
// resolver fails, the first one in the list becomes the active one. This
// group does not fail back automatically.
type FailRotate struct {
id string
resolvers []Resolver
mu sync.RWMutex
active int
metrics *FailRouterMetrics
opt FailRotateOptions
}
// FailRotateOptions contain group-specific options.
type FailRotateOptions struct {
// Determines if a SERVFAIL returned by a resolver should be considered an
// error response and trigger a failover.
ServfailError bool
// Determines if an empty reponse returned by a resolver should be considered an
// error respone and trigger a failover.
EmptyError bool
}
var _ Resolver = &FailRotate{}
// NewFailRotate returns a new instance of a failover resolver group.
func NewFailRotate(id string, opt FailRotateOptions, resolvers ...Resolver) *FailRotate {
return &FailRotate{
id: id,
resolvers: resolvers,
opt: opt,
metrics: NewFailRouterMetrics(id, len(resolvers)),
}
}
// Resolve a DNS query using a failover resolver group that switches to the next
// resolver on error.
func (r *FailRotate) Resolve(q *dns.Msg, ci ClientInfo) (*dns.Msg, error) {
log := logger(r.id, q, ci)
var (
err error
a *dns.Msg
)
for i := 0; i < len(r.resolvers); i++ {
resolver, active := r.current()
log.With("resolver", resolver.String()).Debug("forwarding query to resolver")
r.metrics.route.Add(resolver.String(), 1)
a, err = resolver.Resolve(q, ci)
if err == nil && r.isSuccessResponse(a) { // Return immediately if successful
return a, err
}
log.With("resolver", resolver.String()).Debug("resolver returned failure",
"error", err)
r.metrics.failure.Add(resolver.String(), 1)
r.errorFrom(active)
}
return a, err
}
func (r *FailRotate) String() string {
return r.id
}
// Thread-safe method to return the currently active resolver.
func (r *FailRotate) current() (Resolver, int) {
r.mu.RLock()
defer r.mu.RUnlock()
return r.resolvers[r.active], r.active
}
// Fail over to the next available resolver after receiving an error from i (the active). We
// need i to know which store returned the error as there could be failures from concurrent
// requests. Another request could have initiated the failover already. So ignore if i is not
// (no longer) the active store.
func (r *FailRotate) errorFrom(i int) {
r.mu.Lock()
defer r.mu.Unlock()
if i != r.active {
return
}
r.metrics.failover.Add(1)
r.active = (r.active + 1) % len(r.resolvers)
Log.Debug("failing over to resolver", slog.Group("details", slog.String("id", r.id), slog.String("resolver", r.resolvers[r.active].String())))
}
// Returns true is the response is considered successful given the options.
func (r *FailRotate) isSuccessResponse(a *dns.Msg) bool {
if a == nil {
return true
}
if r.opt.ServfailError && a.Rcode == dns.RcodeServerFailure {
return false
}
if r.opt.EmptyError {
// Check if there are only CNAMEs in the answer section
var onlyCNAME = true
for _, rr := range a.Answer {
if rr.Header().Rrtype != dns.TypeCNAME {
onlyCNAME = false
break
}
}
// The answer may be blank because it was blocked by a filter.
// If so (as determined by the presence of an EDE option), we
// consider it "successful" as we shouldn't retry or fail-over
// in that case.
if onlyCNAME && !hasExtendedErrorBlocked(a) {
return false
}
}
return true
}