From 82df4f0fba651f5ebc14b4f357c59c36df040c92 Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vz-soci@zeitlins.org>
Date: Tue, 22 Apr 2025 20:47:52 +0200
Subject: [PATCH] Remove oracle_soci_error::cat_

This is similar to 025d21ce (Remove postgresql_soci_error::cat_ field,
2025-04-22) but for Oracle backend.
---
 include/soci/oracle/soci-oracle.h |  3 +-
 src/backends/oracle/error.cpp     | 46 +++++++++++++++++--------------
 2 files changed, 27 insertions(+), 22 deletions(-)

diff --git a/include/soci/oracle/soci-oracle.h b/include/soci/oracle/soci-oracle.h
index a4156d47..5c1b37f9 100644
--- a/include/soci/oracle/soci-oracle.h
+++ b/include/soci/oracle/soci-oracle.h
@@ -34,10 +34,9 @@ class SOCI_ORACLE_DECL oracle_soci_error : public soci_error
 public:
     oracle_soci_error(std::string const & msg, int errNum = 0);
 
-    error_category get_error_category() const override { return cat_; }
+    error_category get_error_category() const override;
 
     int err_num_;
-    error_category cat_;
 };
 
 
diff --git a/src/backends/oracle/error.cpp b/src/backends/oracle/error.cpp
index eda75ac1..5c3f2905 100644
--- a/src/backends/oracle/error.cpp
+++ b/src/backends/oracle/error.cpp
@@ -20,33 +20,39 @@ using namespace soci::details;
 using namespace soci::details::oracle;
 
 oracle_soci_error::oracle_soci_error(std::string const & msg, int errNum)
-    : soci_error(msg), err_num_(errNum), cat_(unknown)
+    : soci_error(msg), err_num_(errNum)
 {
-    if (errNum ==  3113 ||
-        errNum ==  3114 ||
-        errNum == 12162 ||
-        errNum == 12541 ||
-        errNum == 25403)
+}
+
+soci_error::error_category oracle_soci_error::get_error_category() const
+{
+    if (err_num_ ==  3113 ||
+        err_num_ ==  3114 ||
+        err_num_ == 12162 ||
+        err_num_ == 12541 ||
+        err_num_ == 25403)
     {
-        cat_ = connection_error;
+        return connection_error;
     }
-    else if (errNum == 1400)
+    else if (err_num_ == 1400)
     {
-        cat_ = constraint_violation;
+        return constraint_violation;
     }
-    else if (errNum == 1466 ||
-        errNum == 2055 ||
-        errNum == 2067 ||
-        errNum == 2091 ||
-        errNum == 2092 ||
-        errNum == 25401 ||
-        errNum == 25402 ||
-        errNum == 25405 ||
-        errNum == 25408 ||
-        errNum == 25409)
+    else if (err_num_ == 1466 ||
+        err_num_ == 2055 ||
+        err_num_ == 2067 ||
+        err_num_ == 2091 ||
+        err_num_ == 2092 ||
+        err_num_ == 25401 ||
+        err_num_ == 25402 ||
+        err_num_ == 25405 ||
+        err_num_ == 25408 ||
+        err_num_ == 25409)
     {
-        cat_ = unknown_transaction_state;
+        return unknown_transaction_state;
     }
+
+    return unknown;
 }
 
 void soci::details::oracle::get_error_details(sword res, OCIError *errhp,