mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Allow changing case of column name in Edit Table dialog

Browse Source 
Allow changing the case of a column name in the Edit Table dialog
without complaining about the name already being taken. This happened
when for example changing a column called 'A' to 'a', making this sort
of changes impossible.

See issue #985.
This commit is contained in:
Martin Kleusberg
2017-03-25 22:19:22 +01:00
parent 43a5175af1
commit 1026e9e777
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/EditTableDialog.cpp
View File

@@ -256,8 +256,15 @@ void EditTableDialog::itemChanged(QTreeWidgetItem *item, int column)
switch(column)
{
case kName:
// When a field of that name already exists, show a warning to the user and don't apply the new name
if(m_table.findField(item->text(column)) != -1)
{
// When a field of that name already exists, show a warning to the user and don't apply the new name. There is one exception, however,
// to this rule: if the field that is about to be renamed the one we're finding here, this can only mean that the user is trying to
// rename the field to essentially the same name but with different case. Example: if I rename column 'COLUMN' to 'column', findField()
// is going to return the current field number because it's doing a case-independent search and it can't return another field number
// because SQLite prohibits duplicate field names (no matter the case). So when this happens we just allow the renaming because there's
// no harm to be expected from it.
int foundField = m_table.findField(item->text(column));
if(foundField != -1 && foundField != index)
{
QMessageBox::warning(this, qApp->applicationName(), tr("There already is a field with that name. Please rename it first or choose a different "
"name for this field."));
@@ -300,7 +307,7 @@ void EditTableDialog::itemChanged(QTreeWidgetItem *item, int column)
qobject_cast<QComboBox*>(ui->treeWidget->itemWidget(item, kType))->setProperty("column", item->text(column));
if(!m_bNewTable)
callRenameColumn = true;
break;
} break;
case kType:
// see updateTypes() SLOT
break;