From 1c0cf443b55e3a06e0c948db7ba6ece50eec278e Mon Sep 17 00:00:00 2001 From: Martin Kleusberg Date: Mon, 8 Feb 2021 18:45:00 +0100 Subject: [PATCH] Fix editing of tables without rowid This fixes some severe bugs in the Browse Data tab with editing and deleting rows in WITHOUT ROWID tables. These were introduced in 02db68107a5c7bf7cc7ccf9ad032d04433f8e60f. See issue #2582. --- src/sqlitetablemodel.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sqlitetablemodel.cpp b/src/sqlitetablemodel.cpp index 1f399822..837d6596 100644 --- a/src/sqlitetablemodel.cpp +++ b/src/sqlitetablemodel.cpp @@ -934,6 +934,9 @@ bool SqliteTableModel::dropMimeData(const QMimeData* data, Qt::DropAction, int r void SqliteTableModel::setPseudoPk(std::vector pseudoPk) { + if(!m_table_of_query->isView()) + return; + if(pseudoPk.empty()) pseudoPk.emplace_back("_rowid_");