mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-21 11:31:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use our Settings class everywhere

Browse Source 
Don't use the QSettings class directly. This keeps the code more
consistent and makes it a bit easier to read. It also means that all
parts of the code profit from the settings cache that we have
implemented in the Settings class.
This commit is contained in:
Martin Kleusberg
2017-10-30 13:37:34 +01:00
parent 9f17176bf6
commit 1ca92cdde3
4 changed files with 65 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/MainWindow.cpp
View File

@@ -35,7 +35,6 @@
#include <QScrollBar>
#include <QSortFilterProxyModel>
#include <QElapsedTimer>
#include <QSettings>
#include <QMimeData>
#include <QColorDialog>
#include <QDesktopServices>
@@ -1909,10 +1908,9 @@ void MainWindow::checkNewVersion(const QString& versionstring, const QString& ur
if(newversion)
{
QSettings settings(QApplication::organizationName(), QApplication::organizationName());
int ignmajor = settings.value("checkversion/ignmajor", 999).toInt();
int ignminor = settings.value("checkversion/ignminor", 0).toInt();
int ignpatch = settings.value("checkversion/ignpatch", 0).toInt();
int ignmajor = Settings::getValue("checkversion", "ignmajor").toInt();
int ignminor = Settings::getValue("checkversion", "ignminor").toInt();
int ignpatch = Settings::getValue("checkversion", "ignpatch").toInt();
// check if the user doesn't care about the current update
if(!(ignmajor == major && ignminor == minor && ignpatch == patch))
@@ -1930,11 +1928,9 @@ void MainWindow::checkNewVersion(const QString& versionstring, const QString& ur
if(msgBox.clickedButton() == idontcarebutton)
{
// save that the user don't want to get bothered about this update
settings.beginGroup("checkversion");
settings.setValue("ignmajor", major);
settings.setValue("ignminor", minor);
settings.setValue("ignpatch", patch);
settings.endGroup();
Settings::setValue("checkversion", "ignmajor", major);
Settings::setValue("checkversion", "ignminor", minor);
Settings::setValue("checkversion", "ignpatch", patch);
}
}
}