mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 02:50:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use references instead of pointers where it's possible

Browse Source 
In our case DDBrowserDB shares lifetime scope with MainWindow, so
there's no need to pass pointers back and forth.
This commit is contained in:
Vladislav Tronko
2016-12-29 20:33:13 +02:00
parent 5697e475b5
commit 210916cfeb
13 changed files with 72 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/MainWindow.cpp
View File

@@ -52,7 +52,7 @@
MainWindow::MainWindow(QWidget* parent)
: QMainWindow(parent),
ui(new Ui::MainWindow),
m_browseTableModel(new SqliteTableModel(this, &db, Settings::getSettingsValue("db", "prefetchsize").toInt())),
m_browseTableModel(new SqliteTableModel(db, this, Settings::getSettingsValue("db", "prefetchsize").toInt())),
m_currentTabTableModel(m_browseTableModel),
editDock(new EditDialog(this)),
gotoValidator(new QIntValidator(0, 0, this))
@@ -713,7 +713,7 @@ void MainWindow::createTable()
return;
}
EditTableDialog dialog(&db, "", true, this);
EditTableDialog dialog(db, "", true, this);
if(dialog.exec())
{
populateTable();
@@ -727,7 +727,7 @@ void MainWindow::createIndex()
return;
}
CreateIndexDialog dialog(&db, this);
CreateIndexDialog dialog(db, this);
dialog.exec();
}
@@ -771,7 +771,7 @@ void MainWindow::editTable()
}
QString tableToEdit = ui->dbTreeWidget->model()->data(ui->dbTreeWidget->currentIndex().sibling(ui->dbTreeWidget->currentIndex().row(), 0)).toString();
EditTableDialog dialog(&db, tableToEdit, false, this);
EditTableDialog dialog(db, tableToEdit, false, this);
if(dialog.exec())
populateTable();
}
@@ -1084,7 +1084,7 @@ void MainWindow::exportTableToCSV()
current_table = ui->comboBrowseTable->currentText();
// Open dialog
ExportDataDialog dialog(&db, ExportDataDialog::ExportFormatCsv, this, "", current_table);
ExportDataDialog dialog(db, ExportDataDialog::ExportFormatCsv, this, "", current_table);
dialog.exec();
}
@@ -1101,7 +1101,7 @@ void MainWindow::exportTableToJson()
current_table = ui->comboBrowseTable->currentText();
// Open dialog
ExportDataDialog dialog(&db, ExportDataDialog::ExportFormatJson, this, "", current_table);
ExportDataDialog dialog(db, ExportDataDialog::ExportFormatJson, this, "", current_table);
dialog.exec();
}
@@ -1554,7 +1554,7 @@ unsigned int MainWindow::openSqlTab(bool resetCounter)
tabNumber = 0;
// Create new tab, add it to the tab widget and select it
SqlExecutionArea* w = new SqlExecutionArea(this, &db);
SqlExecutionArea* w = new SqlExecutionArea(db, this);
int index = ui->tabSqlAreas->addTab(w, QString("SQL %1").arg(++tabNumber));
ui->tabSqlAreas->setCurrentIndex(index);
w->getEditor()->setFocus();