mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-02-09 21:28:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix a ton of warnings from clang, clazy, cppcheck, etc.

Browse Source
This commit is contained in:
Martin Kleusberg
2021-01-22 13:50:49 +01:00
parent 3e06b2e4f9
commit 329c07e0b2
36 changed files with 764 additions and 774 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/AddRecordDialog.cpp
View File

@@ -11,6 +11,8 @@
#include <QLineEdit>
#include <QMenu>
namespace {
class NullLineEdit: public QLineEdit {
Q_OBJECT
private:
@@ -33,23 +35,24 @@ public:
m_isNull = value;
}
protected:
void contextMenuEvent(QContextMenuEvent *event)
{
QMenu* editContextMenu = createStandardContextMenu();
void contextMenuEvent(QContextMenuEvent *event) override
{
QMenu* editContextMenu = createStandardContextMenu();
QAction* nullAction = new QAction(QIcon(":/icons/set_to_null"), tr("Set to NULL"), editContextMenu);
connect(nullAction, &QAction::triggered, [&]() {
setNull(true);
});
nullAction->setShortcut(QKeySequence(tr("Alt+Del")));
editContextMenu->addSeparator();
editContextMenu->addAction(nullAction);
QAction* nullAction = new QAction(QIcon(":/icons/set_to_null"), tr("Set to NULL"), editContextMenu);
connect(nullAction, &QAction::triggered, nullAction, [&]() {
setNull(true);
});
nullAction->setShortcut(QKeySequence(tr("Alt+Del")));
editContextMenu->addSeparator();
editContextMenu->addAction(nullAction);
editContextMenu->exec(event->globalPos());
delete editContextMenu;
}
editContextMenu->exec(event->globalPos());
delete editContextMenu;
}
void keyPressEvent(QKeyEvent *evt) {
void keyPressEvent(QKeyEvent *evt) override
{
// Alt+Del sets field to NULL
if((evt->modifiers() & Qt::AltModifier) && (evt->key() == Qt::Key_Delete))
setNull(true);
@@ -112,6 +115,9 @@ public:
}
};
}
AddRecordDialog::AddRecordDialog(DBBrowserDB& db, const sqlb::ObjectIdentifier& tableName, QWidget* parent, const std::vector<std::string>& _pseudo_pk)
: QDialog(parent),
ui(new Ui::AddRecordDialog),
@@ -188,8 +194,10 @@ void AddRecordDialog::populateFields()
{
sqlb::TablePtr m_table = pdb.getObjectByName<sqlb::Table>(curTable);
fields = m_table->fields;
for(const sqlb::Field& f : fields)
fks.push_back(m_table->constraint({f.name()}, sqlb::Constraint::ForeignKeyConstraintType));
std::transform(fields.begin(), fields.end(), std::back_inserter(fks), [m_table](const auto& f) {
return m_table->constraint({f.name()}, sqlb::Constraint::ForeignKeyConstraintType);
});
const auto pk_constraint = m_table->primaryKey();
if(pk_constraint)