From 3be5969bca14684d6b9e9ceebad354b1ee204ca1 Mon Sep 17 00:00:00 2001
From: Martin Kleusberg <github@mkleusberg.de>
Date: Sat, 22 May 2021 10:28:49 +0200
Subject: [PATCH] Do not always refresh the table browser dock when opening a
 database

It does not seem like there is a good reason to always refresh the table
browser dock (there is always exactly one at this point) when opening a
database file, even when it is not visible. This only generates
unnecessary queries to the database.
---
 src/MainWindow.cpp | 6 +++---
 src/MainWindow.h   | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
index 3a0652ed..20dfe532 100644
--- a/src/MainWindow.cpp
+++ b/src/MainWindow.cpp
@@ -566,7 +566,7 @@ bool MainWindow::fileOpen(const QString& fileName, bool openFromProject, bool re
                 else if(ui->mainTab->currentWidget() == ui->pragmas)
                     loadPragmas();
 
-                refreshTableBrowsers(true);
+                refreshTableBrowsers();
 
                 // Update remote dock
                 remoteDock->fileOpened(wFile);
@@ -672,14 +672,14 @@ void MainWindow::populateStructure(const std::vector<sqlb::ObjectIdentifier>& ol
     ui->treeSchemaDock->resizeColumnToContents(DbStructureModel::ColumnName);
 }
 
-void MainWindow::refreshTableBrowsers(bool force_refresh)
+void MainWindow::refreshTableBrowsers()
 {
     QApplication::setOverrideCursor(Qt::WaitCursor);
     for(const auto& d : allTableBrowserDocks())
     {
         // When in the Browse Data tab update all docks. Otherwise just update the floating ones because they might
         // be visible even when another tab is active.
-        if(force_refresh || ui->mainTab->currentWidget() == ui->browser || d->isFloating())
+        if(ui->mainTab->currentWidget() == ui->browser || d->isFloating())
         {
             TableBrowser* t = d->tableBrowser();
             if(t)
diff --git a/src/MainWindow.h b/src/MainWindow.h
index 441cc4dd..9b1cfb16 100644
--- a/src/MainWindow.h
+++ b/src/MainWindow.h
@@ -166,7 +166,7 @@ private slots:
     void changeTreeSelection();
     void fileNew();
     void fileNewInMemoryDatabase(bool open_create_dialog = true);
-    void refreshTableBrowsers(bool force_refresh = false);
+    void refreshTableBrowsers();
     bool fileClose();
     bool fileSaveAs();
     void createTable();