mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-02-10 05:38:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

Make use of the improved ALTER TABLE abilities from SQLite 3.25.0

Browse Source 
SQLite 3.25.0 introduced an extended ALTER TABLE command which now
allows renaming an existing field. Before this we were emulating this
functionality in our code. There are however three reasons to switch to
the new feature from SQLite, even though it doesn't safe us any code:
1) It is faster because it does less steps
2) It is less error prone for the same reason
3) It is better at also renaming the field in triggers and views

This is somewhat improving the situation in issue #1444 but not
addressing the main problem described there.
This commit is contained in:
Martin Kleusberg
2018-10-09 21:13:23 +02:00
parent aaa88367ba
commit 5ec03baef4
2 changed files with 52 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sqlitedb.h
View File

@@ -152,7 +152,7 @@ public:
* @param newSchema Set this to a non-empty string to move the table to a new schema
* @return true if renaming was successful, false if not. In the latter case also lastErrorMessage is set
*/
bool alterTable(const sqlb::ObjectIdentifier& tablename, const sqlb::Table& table, const QString& name, const sqlb::Field* to, int move = 0, QString newSchemaName = QString());
bool alterTable(const sqlb::ObjectIdentifier& tablename, const sqlb::Table& table, QString name, const sqlb::Field* to, int move = 0, QString newSchemaName = QString());
objectMap getBrowsableObjects(const QString& schema) const;