mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-05-14 07:49:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't crash when pasting data in a view

Browse Source 
When pasting data into a cell of a view the application would have
crashed because it treats the view as a table (which it isn't). This is
fixed by this.
This commit is contained in:
Martin Kleusberg
2017-06-21 23:25:53 +02:00
parent 6984d451d6
commit 61f385abba
1 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/sqlitedb.cpp
+19 -1
View File
@@ -959,10 +959,28 @@ bool DBBrowserDB::updateRecord(const QString& table, const QString& column, cons
{
if (!isOpen()) return false;
// Get primary key of the object to edit. For views we support 'pseudo' primary keys which must be specified manually.
// If no pseudo pk is specified we'll take the rowid column of the table. If this isn't a table, however, we'll just assume
// it's a view that hasn't been configured for editing and thus abort here.
QString pk;
if(pseudo_pk.isEmpty())
{
sqlb::TablePtr tbl = getObjectByName(table).dynamicCast<sqlb::Table>();
if(tbl)
{
pk = tbl->rowidColumn();
} else {
lastErrorMessage = tr("Cannot set data on this object");
return false;
}
} else {
pk = pseudo_pk;
}
QString sql = QString("UPDATE %1 SET %2=? WHERE %3='%4';")
.arg(sqlb::escapeIdentifier(table))
.arg(sqlb::escapeIdentifier(column))
.arg(sqlb::escapeIdentifier(pseudo_pk.isEmpty() ? getObjectByName(table).dynamicCast<sqlb::Table>()->rowidColumn() : pseudo_pk))
.arg(pk)
.arg(rowid);
logSQL(sql, kLogMsg_App);