mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 19:11:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Support non-integer primary keys

Browse Source 
Add support for non-integer primary keys, especially on table without
rowid column. The previous code often assumed that the rowid column or
its equivalent was a 64bit integer but SQLite allows any data, including
text, to be stored in there.

See issue #240.
This commit is contained in:
Martin Kleusberg
2015-04-25 14:10:22 +02:00
parent d6533ba5f7
commit 6d196c004a
3 changed files with 39 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sqlitetablemodel.cpp
View File

@@ -282,7 +282,7 @@ bool SqliteTableModel::setData(const QModelIndex& index, const QVariant& value,
if(oldValue == newValue && oldValue.isNull() == newValue.isNull())
return true;
if(m_db->updateRecord(m_sTable, m_headers.at(index.column()), m_data[index.row()].at(0).toLongLong(), newValue, isBinary(index)))
if(m_db->updateRecord(m_sTable, m_headers.at(index.column()), m_data[index.row()].at(0), newValue, isBinary(index)))
{
// Only update the cache if this row has already been read, if not there's no need to do any changes to the cache
if(index.row() < m_data.size())
@@ -345,14 +345,14 @@ bool SqliteTableModel::insertRows(int row, int count, const QModelIndex& parent)
DataType tempList;
for(int i=row; i < row + count; ++i)
{
qint64 rowid = m_db->addRecord(m_sTable);
if(rowid < 0)
QString rowid = m_db->addRecord(m_sTable);
if(rowid.isNull())
{
return false;
}
m_rowCount++;
tempList.append(blank_data);
tempList[i - row].replace(0, QByteArray::number(rowid));
tempList[i - row].replace(0, rowid.toUtf8());
// update column with default values
QByteArrayList rowdata;
@@ -380,7 +380,7 @@ bool SqliteTableModel::removeRows(int row, int count, const QModelIndex& parent)
for(int i=count-1;i>=0;i--)
{
m_db->deleteRecord(m_sTable, m_data.at(row + i).at(0).toLongLong());
m_db->deleteRecord(m_sTable, m_data.at(row + i).at(0));
m_data.removeAt(row + i);
}