mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-02-11 06:08:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Speed up executing SQL statements in the Execute SQL tab

Browse Source 
This improves the performance of executing multiple modifying SQL
statements, like INSERTs or UPDATEs, in the Execute SQL tab a lot by
not updating the plot dock after every single statement.

See issue #2572.
This commit is contained in:
Martin Kleusberg
2021-02-03 19:16:50 +01:00
parent 1e2853bfea
commit 73efa11680
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/MainWindow.cpp
View File

@@ -1231,19 +1231,15 @@ void MainWindow::executeQuery()
connect(execute_sql_worker.get(), &RunSql::structureUpdated, sqlWidget, [this]() {
db.updateSchema();
}, Qt::QueuedConnection);
connect(execute_sql_worker.get(), &RunSql::statementErrored, sqlWidget, [query_logger, this, sqlWidget](const QString& status_message, int from_position, int to_position) {
sqlWidget->getModel()->reset();
connect(execute_sql_worker.get(), &RunSql::statementErrored, sqlWidget, [query_logger, this](const QString& status_message, int from_position, int to_position) {
ui->actionSqlResultsSave->setEnabled(false);
ui->actionSqlResultsSaveAsView->setEnabled(false);
attachPlot(sqlWidget->getTableResult(), sqlWidget->getModel());
query_logger(false, status_message, from_position, to_position);
}, Qt::QueuedConnection);
connect(execute_sql_worker.get(), &RunSql::statementExecuted, sqlWidget, [query_logger, this, sqlWidget](const QString& status_message, int from_position, int to_position) {
sqlWidget->getModel()->reset();
connect(execute_sql_worker.get(), &RunSql::statementExecuted, sqlWidget, [query_logger, this](const QString& status_message, int from_position, int to_position) {
ui->actionSqlResultsSave->setEnabled(false);
ui->actionSqlResultsSaveAsView->setEnabled(false);
attachPlot(sqlWidget->getTableResult(), sqlWidget->getModel());
query_logger(true, status_message, from_position, to_position);
execute_sql_worker->startNextStatement();
@@ -1319,6 +1315,10 @@ void MainWindow::executeQuery()
// Make the SQL editor widget read-only. We do this because the error indicators would be misplaced if the user changed the SQL text during execution
sqlWidget->getEditor()->setReadOnly(true);
// Reset model and clear plot dock
sqlWidget->getModel()->reset();
attachPlot(sqlWidget->getTableResult(), sqlWidget->getModel());
// Start the execution
execute_sql_worker->start();
}