From 8a4838057d9cd5f61490a6f58903526380d3a529 Mon Sep 17 00:00:00 2001 From: Samir Aguiar Date: Mon, 9 Feb 2015 22:04:01 +0100 Subject: [PATCH] preferencesdialog: Remove unnecessary sort model Turns out that the use of a QSortFilterProxyModel wasn't necessary, as it's possible to sort the QCombobox using its model directly. --- src/PreferencesDialog.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/PreferencesDialog.cpp b/src/PreferencesDialog.cpp index 41458067..4d15058d 100644 --- a/src/PreferencesDialog.cpp +++ b/src/PreferencesDialog.cpp @@ -7,7 +7,6 @@ #include #include #include -#include QHash PreferencesDialog::m_hCache; @@ -18,15 +17,6 @@ PreferencesDialog::PreferencesDialog(QWidget* parent) ui->setupUi(this); ui->treeSyntaxHighlighting->setColumnHidden(0, true); - // Model to sort the languages in the language combo box - QSortFilterProxyModel *proxy = new QSortFilterProxyModel(ui->languageComboBox); - proxy->setSourceModel(ui->languageComboBox->model()); - - // Prevent setModel() from deleting the current model (now source of the proxy model) - ui->languageComboBox->model()->setParent(proxy); - - ui->languageComboBox->setModel(proxy); - loadSettings(); }