From 93a5c2d0ca81fb26c51a9e0ecabacfc7ab872d62 Mon Sep 17 00:00:00 2001 From: mgrojo Date: Sat, 20 Mar 2021 14:16:23 +0100 Subject: [PATCH] Import: don't assume an empty file is a text file Since in any case, the empty file has nothing to import and it's admitted by SQLite as a valid database, it's better to revert to the previous behaviour, where an empty file dropped or opened by the file manager was treated as a DB and indeed worked. The behaviour was changed by cfa4dee3be69ace34cfdd4c2b4a8accc067bdbe7 See issue #2636 --- src/Data.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Data.cpp b/src/Data.cpp index 7fc5c94a..bd27dfcd 100644 --- a/src/Data.cpp +++ b/src/Data.cpp @@ -65,7 +65,7 @@ bool isTextOnlyFile(const QString& fileName) QFile file(fileName); if (file.open(QFile::ReadOnly)) { QByteArray data = file.read(512); - return isTextOnly(data); + return !data.isEmpty() && isTextOnly(data); } else { return false; }