mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-05-18 03:29:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

Do not print an error message when a PRAGMA did not return any value

Browse Source 
When a PRAGMA query did not return any value (most notably the PRAGMA
foreign_key_check after editing a table using the Edit Table dialog), we
used to print an error message to the console. There were no further
side effects but the message could be irritating. This extra error
message is removed by this commit.

See issue #1868.
This commit is contained in:
Martin Kleusberg
2019-05-01 22:10:06 +02:00
parent a1b43bca73
commit a88fad2145
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/sqlitedb.cpp
+7 -2
View File
@@ -1152,7 +1152,12 @@ QByteArray DBBrowserDB::querySingleValueFromDb(const QString& sql, bool log, Cho
sqlite3_stmt* stmt;
if(sqlite3_prepare_v2(_db, utf8Query, utf8Query.size(), &stmt, nullptr) == SQLITE_OK)
{
if(sqlite3_step(stmt) == SQLITE_ROW)
// Execute the statement. We distinguish three types of results:
// SQLITE_ROW in case some data was returned from the database. This data is then used as a return value.
// SQLITE_DONE in case the statement executed successfully but did not return any data. We do nothing in this case, leaving the return value empty.
// Any other case is an error, so we need to prepare an error message.
int result = sqlite3_step(stmt);
if(result == SQLITE_ROW)
{
if(sqlite3_column_count(stmt) > 0 && sqlite3_column_type(stmt, 0) != SQLITE_NULL)
{
@@ -1162,7 +1167,7 @@ QByteArray DBBrowserDB::querySingleValueFromDb(const QString& sql, bool log, Cho
else
retval = "";
}
} else {
} else if(result != SQLITE_DONE) {
lastErrorMessage = tr("didn't receive any output from %1").arg(sql);
qWarning() << lastErrorMessage;
}