From ba9931ac7f69edbf0fcf68cb08bb44fd31737fa8 Mon Sep 17 00:00:00 2001
From: Martin Kleusberg <mkleusberg@gmail.com>
Date: Wed, 27 Aug 2014 18:48:18 +0200
Subject: [PATCH] EditTableDialog: Add without rowid checkbox

Add a checkbox for setting the 'WITHOUT rowid' flag in the
EditTableDialog. All functionality concerning the checkbox is
implemented by this commit with one exception: Setting/unsetting the
flag on an existing table won't perform any changes yet.

See issue #51.
---
 src/EditTableDialog.cpp |  32 +++++++++++++
 src/EditTableDialog.h   |   1 +
 src/EditTableDialog.ui  | 100 ++++++++++++++++++++++++++++++++++------
 3 files changed, 118 insertions(+), 15 deletions(-)

diff --git a/src/EditTableDialog.cpp b/src/EditTableDialog.cpp
index 295c116c..94ed88db 100644
--- a/src/EditTableDialog.cpp
+++ b/src/EditTableDialog.cpp
@@ -20,6 +20,7 @@ EditTableDialog::EditTableDialog(DBBrowserDB* db, const QString& tableName, QWid
 {
     // Create UI
     ui->setupUi(this);
+    ui->widgetExtension->setVisible(false);
     connect(ui->treeWidget, SIGNAL(itemChanged(QTreeWidgetItem*,int)),this,SLOT(itemChanged(QTreeWidgetItem*,int)));
 
     m_sqliteSyntaxHighlighter = new SQLiteSyntaxHighlighter(ui->sqlTextEdit->document());
@@ -32,6 +33,7 @@ EditTableDialog::EditTableDialog(DBBrowserDB* db, const QString& tableName, QWid
         // Existing table, so load and set the current layout
         QString sTablesql = pdb->getObjectByName(curTable).getsql();
         m_table = sqlb::Table::parseSQL(sTablesql).first;
+        ui->checkWithoutRowid->setChecked(m_table.isWithoutRowidTable());
         populateFields();
     }
 
@@ -490,3 +492,33 @@ void EditTableDialog::moveCurrentField(bool down)
     // Update the SQL preview
     updateSqlText();
 }
+
+void EditTableDialog::setWithoutRowid(bool without_rowid)
+{
+    if(without_rowid)
+    {
+        // Before setting the without rowid flag, first perform a check to see if the table meets all thr required criteria for without rowid tables
+        int pk = m_table.findPk();
+        if(pk == -1 || m_table.fields().at(pk)->isInteger() == false || m_table.fields().at(pk)->autoIncrement())
+        {
+            QMessageBox::information(this, QApplication::applicationName(),
+                                     tr("Please add a field which meets the following criteria before setting the without rowid flag:\n"
+                                        " - Primary key flag set\n"
+                                        " - Auto incremenct disabled\n"
+                                        " - Type INTEGER"));
+            ui->checkWithoutRowid->setChecked(false);
+            return;
+        }
+
+        // If it does, override the the rowid column name of the table object with the name of the primary key.
+        m_table.setRowidColumn(m_table.fields().at(pk)->name());
+    } else {
+        // If the without rowid flag is unset no further checks are required. Just set the rowid column name back to "_rowid_"
+        m_table.setRowidColumn("_rowid_");
+    }
+
+    // Update the SQL preview
+    updateSqlText();
+
+    // TODO: Update table if we're editing an existing table
+}
diff --git a/src/EditTableDialog.h b/src/EditTableDialog.h
index 7769caf2..e4b10418 100644
--- a/src/EditTableDialog.h
+++ b/src/EditTableDialog.h
@@ -50,6 +50,7 @@ private slots:
     virtual void updateTypes();
     virtual void moveUp();
     virtual void moveDown();
+    virtual void setWithoutRowid(bool without_rowid);
 
 private:
     Ui::EditTableDialog* ui;
diff --git a/src/EditTableDialog.ui b/src/EditTableDialog.ui
index ea2fefe1..ae99f514 100644
--- a/src/EditTableDialog.ui
+++ b/src/EditTableDialog.ui
@@ -37,6 +37,38 @@
         </property>
        </widget>
       </item>
+      <item>
+       <widget class="QToolButton" name="buttonMore">
+        <property name="text">
+         <string>Advanced</string>
+        </property>
+        <property name="checkable">
+         <bool>true</bool>
+        </property>
+        <property name="toolButtonStyle">
+         <enum>Qt::ToolButtonTextBesideIcon</enum>
+        </property>
+        <property name="arrowType">
+         <enum>Qt::DownArrow</enum>
+        </property>
+       </widget>
+      </item>
+      <item>
+       <widget class="QWidget" name="widgetExtension" native="true">
+        <layout class="QVBoxLayout" name="verticalLayout_5">
+         <item>
+          <widget class="QCheckBox" name="checkWithoutRowid">
+           <property name="toolTip">
+            <string>Make this a 'WITHOUT rowid' table. Setting this flag requires a field of type INTEGER with the primary key flag set and the auto increment flag unset.</string>
+           </property>
+           <property name="text">
+            <string>Without Rowid</string>
+           </property>
+          </widget>
+         </item>
+        </layout>
+       </widget>
+      </item>
      </layout>
     </widget>
    </item>
@@ -265,9 +297,14 @@
  </widget>
  <tabstops>
   <tabstop>editTableName</tabstop>
+  <tabstop>buttonMore</tabstop>
+  <tabstop>checkWithoutRowid</tabstop>
   <tabstop>addFieldButton</tabstop>
   <tabstop>removeFieldButton</tabstop>
-  <tabstop>buttonBox</tabstop>
+  <tabstop>buttonMoveUp</tabstop>
+  <tabstop>buttonMoveDown</tabstop>
+  <tabstop>treeWidget</tabstop>
+  <tabstop>sqlTextEdit</tabstop>
  </tabstops>
  <resources>
   <include location="icons/icons.qrc"/>
@@ -280,8 +317,8 @@
    <slot>accept()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>252</x>
-     <y>400</y>
+     <x>261</x>
+     <y>590</y>
     </hint>
     <hint type="destinationlabel">
      <x>157</x>
@@ -296,8 +333,8 @@
    <slot>reject()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>320</x>
-     <y>400</y>
+     <x>329</x>
+     <y>590</y>
     </hint>
     <hint type="destinationlabel">
      <x>286</x>
@@ -312,8 +349,8 @@
    <slot>fieldSelectionChanged()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>116</x>
-     <y>193</y>
+     <x>137</x>
+     <y>367</y>
     </hint>
     <hint type="destinationlabel">
      <x>411</x>
@@ -328,8 +365,8 @@
    <slot>addField()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>57</x>
-     <y>106</y>
+     <x>79</x>
+     <y>203</y>
     </hint>
     <hint type="destinationlabel">
      <x>79</x>
@@ -344,8 +381,8 @@
    <slot>removeField()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>276</x>
-     <y>111</y>
+     <x>232</x>
+     <y>203</y>
     </hint>
     <hint type="destinationlabel">
      <x>249</x>
@@ -376,8 +413,8 @@
    <slot>moveUp()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>282</x>
-     <y>107</y>
+     <x>356</x>
+     <y>203</y>
     </hint>
     <hint type="destinationlabel">
      <x>308</x>
@@ -392,8 +429,8 @@
    <slot>moveDown()</slot>
    <hints>
     <hint type="sourcelabel">
-     <x>413</x>
-     <y>107</y>
+     <x>497</x>
+     <y>203</y>
     </hint>
     <hint type="destinationlabel">
      <x>308</x>
@@ -401,6 +438,38 @@
     </hint>
    </hints>
   </connection>
+  <connection>
+   <sender>buttonMore</sender>
+   <signal>toggled(bool)</signal>
+   <receiver>widgetExtension</receiver>
+   <slot>setVisible(bool)</slot>
+   <hints>
+    <hint type="sourcelabel">
+     <x>97</x>
+     <y>78</y>
+    </hint>
+    <hint type="destinationlabel">
+     <x>103</x>
+     <y>98</y>
+    </hint>
+   </hints>
+  </connection>
+  <connection>
+   <sender>checkWithoutRowid</sender>
+   <signal>toggled(bool)</signal>
+   <receiver>EditTableDialog</receiver>
+   <slot>setWithoutRowid(bool)</slot>
+   <hints>
+    <hint type="sourcelabel">
+     <x>324</x>
+     <y>113</y>
+    </hint>
+    <hint type="destinationlabel">
+     <x>324</x>
+     <y>299</y>
+    </hint>
+   </hints>
+  </connection>
  </connections>
  <slots>
   <slot>fieldSelectionChanged()</slot>
@@ -411,5 +480,6 @@
   <slot>itemChanged()</slot>
   <slot>moveUp()</slot>
   <slot>moveDown()</slot>
+  <slot>setWithoutRowid(bool)</slot>
  </slots>
 </ui>