From c8ea53bf4f06aeec2201a427f34ad446f968b0a4 Mon Sep 17 00:00:00 2001 From: Samir Aguiar Date: Fri, 20 Mar 2015 23:31:45 +0100 Subject: [PATCH] qhexedit: Fix initialization order in QHexEditPrivate This prevents use of uninitialized values in conditional jumps as reported by Valgrind. It's already fixed in QHexEdit repository. --- libs/qhexedit/src/qhexedit_p.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libs/qhexedit/src/qhexedit_p.cpp b/libs/qhexedit/src/qhexedit_p.cpp index ab1ad908..65f5cbbd 100644 --- a/libs/qhexedit/src/qhexedit_p.cpp +++ b/libs/qhexedit/src/qhexedit_p.cpp @@ -16,12 +16,16 @@ QHexEditPrivate::QHexEditPrivate(QScrollArea *parent) : QWidget(parent) _undoStack = new QUndoStack(this); _scrollArea = parent; + _asciiArea = true; + + setOverwriteMode(true); + setCursorPos(0); + setAddressArea(true); + setAddressWidth(4); setAddressOffset(0); - setAddressArea(true); setAsciiArea(true); setHighlighting(true); - setOverwriteMode(true); setReadOnly(false); setAddressAreaColor(QColor(0xd4, 0xd4, 0xd4, 0xff)); setHighlightingColor(QColor(0xff, 0xff, 0x99, 0xff));