mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-21 11:31:00 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixes and improvements in user messages

Browse Source 
- Title for the File Extension Manager
- Independent messages for each object type. See issue #1490
- Fixed incorrect wording in "What's This" message
This commit is contained in:
mgrojo
2018-08-03 18:49:25 +02:00
parent 241372e6eb
commit d65427a8a6
3 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/MainWindow.cpp
View File

@@ -886,16 +886,36 @@ void MainWindow::deleteObject()
ui->dbTreeWidget->model()->data(ui->dbTreeWidget->currentIndex().sibling(ui->dbTreeWidget->currentIndex().row(), DbStructureModel::ColumnName), Qt::EditRole).toString());
QString type = ui->dbTreeWidget->model()->data(ui->dbTreeWidget->currentIndex().sibling(ui->dbTreeWidget->currentIndex().row(), DbStructureModel::ColumnObjectType), Qt::EditRole).toString();
// Due to different grammar in languages (e.g. gender or declension), each message must be given separately to translation.
QString message;
if (type == "table")
message = tr("Are you sure you want to delete the table '%1'?\nAll data associated with the table will be lost.");
else if (type == "view")
message = tr("Are you sure you want to delete the view '%1'?");
else if (type == "trigger")
message = tr("Are you sure you want to delete the trigger '%1'?");
else if (type == "index")
message = tr("Are you sure you want to delete the index '%1'?");
// Ask user if he really wants to delete that table
if(QMessageBox::warning(this, QApplication::applicationName(), tr("Are you sure you want to delete the %1 '%2'?\nAll data associated with the %1 will be lost.").arg(type).arg(name.name()),
if(QMessageBox::warning(this, QApplication::applicationName(), message.arg(name.name()),
QMessageBox::Yes | QMessageBox::No, QMessageBox::No) == QMessageBox::Yes)
{
// Delete the table
QString statement = QString("DROP %1 %2;").arg(type.toUpper()).arg(name.toString());
if(!db.executeSQL(statement))
{
QString error = tr("Error: could not delete the %1. Message from database engine:\n%2").arg(type).arg(db.lastError());
QMessageBox::warning(this, QApplication::applicationName(), error);
if (type == "table")
message = tr("Error: could not delete the table.");
else if (type == "view")
message = tr("Error: could not delete the view.");
else if (type == "trigger")
message = tr("Error: could not delete the trigger.");
else if (type == "index")
message = tr("Error: could not delete the index.");
QString error = tr("Message from database engine:\n%1").arg(db.lastError());
QMessageBox::warning(this, QApplication::applicationName(), message + " " + error);
} else {
populateTable();
changeTreeSelection();