From e8a03f462cc00fbc312144e5cd062ca8cdfc27ea Mon Sep 17 00:00:00 2001 From: Martin Kleusberg Date: Wed, 28 Nov 2018 12:13:38 +0100 Subject: [PATCH] Fix bug in 9e36f21112567dcdef7bbe9af60f821d5e862a2a This fixes a bug in the code to modify multiple table columns in one go. We were accidentally adding more tracked columns when adding a new column and then changing its name. See issue #1627. --- src/EditTableDialog.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/EditTableDialog.cpp b/src/EditTableDialog.cpp index bab5878a..9f5f05cc 100644 --- a/src/EditTableDialog.cpp +++ b/src/EditTableDialog.cpp @@ -323,7 +323,7 @@ void EditTableDialog::itemChanged(QTreeWidgetItem *item, int column) // Update the field name in the map of old column names to new column names if(!m_bNewTable) { - for(const auto& key : trackColumns) + for(const auto& key : trackColumns.keys()) { if(trackColumns[key] == oldFieldName) trackColumns[key] = field.name(); @@ -588,7 +588,7 @@ void EditTableDialog::removeField() // Update the map of tracked columns to indicate the column is deleted QString name = ui->treeWidget->currentItem()->text(0); - for(const auto& key : trackColumns) + for(const auto& key : trackColumns.keys()) { if(trackColumns[key] == name) trackColumns[key] = QString();