mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-29 07:19:46 -06:00
Code Issues Packages Projects Releases Wiki Activity

Removed code for changing the default Qt behaviour for read-only+selectable

Browse Source 
This code was added for #1123 but it isn't working well, some times the
read-only style is used when the cell is writable and vice versa. It has
also problems in the Dark Style mode.

So it is better to remove this code, the read-only characteristic is
hinted by the non-blinking caret. The same should be done for the
QScintilla editors, but it does not have such method.

See issue #1493
This commit is contained in:
mgrojo
2019-03-04 20:42:53 +01:00
parent baaeea8844
commit e9d8af6059
1 changed files with 3 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/EditDialog.cpp
View File

@@ -864,7 +864,6 @@ void EditDialog::setFocus()
void EditDialog::setReadOnly(bool ro)
{
isReadOnly = ro;
QPalette textEditPalette = ui->editorText->palette();
ui->buttonApply->setEnabled(!ro);
ui->actionNull->setEnabled(!ro);
@@ -874,24 +873,11 @@ void EditDialog::setReadOnly(bool ro)
sciEdit->setReadOnly(ro);
hexEdit->setReadOnly(ro);
// This makes the caret being visible for selection, although the editor is read-only.
// This makes the caret being visible for selection, although the editor is read-only. The read-only state is hinted by the
// caret not blinking. The same should happen for QScintilla, but it always lets the user select text by keyboard (ok) but
// the caret is also blinking when in read-only mode (not ok).
Qt::TextInteractionFlags textFlags = ro? Qt::TextSelectableByMouse | Qt::TextSelectableByKeyboard : Qt::TextEditorInteraction;
ui->editorText->setTextInteractionFlags(textFlags);
// If read-only, set the Disabled palette settings for the (in)active groups, so the user gets a hint about the text being read-only.
// This should be set also for the Scintilla widget, but it isn't working for that.
if (ro) {
textEditPalette.setColor(QPalette::Active, QPalette::Base, textEditPalette.color(QPalette::Disabled, QPalette::Base));
textEditPalette.setColor(QPalette::Inactive, QPalette::Base, textEditPalette.color(QPalette::Disabled, QPalette::Base));
textEditPalette.setColor(QPalette::Active, QPalette::Highlight, textEditPalette.color(QPalette::Disabled, QPalette::Highlight));
textEditPalette.setColor(QPalette::Inactive, QPalette::Highlight, textEditPalette.color(QPalette::Disabled, QPalette::Highlight));
textEditPalette.setColor(QPalette::Active, QPalette::HighlightedText, textEditPalette.color(QPalette::Disabled, QPalette::HighlightedText));
textEditPalette.setColor(QPalette::Inactive, QPalette::HighlightedText, textEditPalette.color(QPalette::Disabled, QPalette::HighlightedText));
ui->editorText->setPalette(textEditPalette);
} else {
// Restore default palette
ui->editorText->setPalette(QPalette());
}
}
void EditDialog::switchEditorMode(bool autoSwitchForType)