mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

Better error handling in import CSV dialog

Browse Source 
Make sure to show the correct error message when there is an error
during CSV import.

Make sure to release the DB handle used for the import before rolling
back to the last savepoint in case of an error in the CSV import. This
avoids a deadlock situation.

See issue #1590.
This commit is contained in:
Martin Kleusberg
2018-10-23 19:52:34 +02:00
parent 5ec03baef4
commit f11b1a0445
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/ImportCsvDialog.cpp
View File

@@ -100,10 +100,15 @@ namespace {
void rollback(
ImportCsvDialog* dialog,
DBBrowserDB* pdb,
DBBrowserDB::db_pointer_type* db_ptr,
const QString& savepointName,
size_t nRecord,
const QString& message)
{
// Release DB handle. This needs to be done before calling revertToSavepoint as that function needs to be able to acquire its own handle.
if(db_ptr)
*db_ptr = nullptr;
QApplication::restoreOverrideCursor(); // restore original cursor
if(!message.isEmpty())
{
@@ -533,7 +538,7 @@ bool ImportCsvDialog::importCsv(const QString& fileName, const QString& name)
QString restorepointName = pdb->generateSavepointName("csvimport");
if(!pdb->setSavepoint(restorepointName))
{
rollback(this, pdb, restorepointName, 0, tr("Creating restore point failed: %1").arg(pdb->lastError()));
rollback(this, pdb, nullptr, restorepointName, 0, tr("Creating restore point failed: %1").arg(pdb->lastError()));
return false;
}
@@ -546,7 +551,7 @@ bool ImportCsvDialog::importCsv(const QString& fileName, const QString& name)
{
if(!pdb->createTable(sqlb::ObjectIdentifier("main", tableName), fieldList))
{
rollback(this, pdb, restorepointName, 0, tr("Creating the table failed: %1").arg(pdb->lastError()));
rollback(this, pdb, nullptr, restorepointName, 0, tr("Creating the table failed: %1").arg(pdb->lastError()));
return false;
}
@@ -672,13 +677,15 @@ bool ImportCsvDialog::importCsv(const QString& fileName, const QString& name)
// Some error occurred or the user cancelled the action
// Rollback the entire import. If the action was cancelled, don't show an error message. If it errored, show an error message.
sqlite3_finalize(stmt);
if(result == CSVParser::ParserResult::ParserResultCancelled)
{
rollback(this, pdb, restorepointName, 0, QString());
sqlite3_finalize(stmt);
rollback(this, pdb, &pDb, restorepointName, 0, QString());
return false;
} else {
rollback(this, pdb, restorepointName, lastRowNum, tr("Inserting row failed: %1").arg(pdb->lastError()));
QString error(sqlite3_errmsg(pDb.get()));
sqlite3_finalize(stmt);
rollback(this, pdb, &pDb, restorepointName, lastRowNum, tr("Inserting row failed: %1").arg(error));
return false;
}
}