mirror/sqlitebrowser
1
0
Fork 0
mirror of https://github.com/sqlitebrowser/sqlitebrowser.git synced 2026-01-20 11:00:44 -06:00
Code Issues Packages Projects Releases Wiki Activity

DBBrowserDB: Remove the dirty flag

Browse Source 
Remove the dirty flag as it is no longer needed. Because we track the
savepoints currently held open we can just use that list to see wether
there are changes to be committed. So there is no need to track this in
a separate variable.
This commit is contained in:
Martin Kleusberg
2013-05-23 18:16:58 +02:00
parent 6de8425985
commit f3ae25572d
3 changed files with 6 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/sqlitedb.cpp
View File

@@ -20,16 +20,9 @@ bool DBBrowserDB::isOpen ( ) const
return _db!=0;
}
void DBBrowserDB::setDirty(bool dirtyval)
{
dirty = dirtyval;
if(mainWindow)
mainWindow->dbState(dirtyval);
}
bool DBBrowserDB::getDirty() const
{
return dirty;
return !savepointList.empty();
}
bool DBBrowserDB::open ( const QString & db)
@@ -77,7 +70,6 @@ bool DBBrowserDB::open ( const QString & db)
if (SQLITE_OK==sqlite3_exec(_db,"PRAGMA show_datatypes = ON;",
NULL,NULL,NULL)){
ok=true;
setDirty(false);
}
curDBFilename = db;
}
@@ -101,7 +93,7 @@ bool DBBrowserDB::setRestorePoint(const QString& pointname)
QString query = QString("SAVEPOINT %1;").arg(pointname);
sqlite3_exec(_db, query.toUtf8(), NULL, NULL, NULL);
savepointList.append(pointname);
setDirty(true);
if(mainWindow) mainWindow->dbState(getDirty());
}
return true;
}
@@ -116,7 +108,7 @@ bool DBBrowserDB::save(const QString& pointname)
QString query = QString("RELEASE %1;").arg(pointname);
sqlite3_exec(_db, query.toUtf8(), NULL,NULL,NULL);
savepointList.removeAll(pointname);
setDirty(!savepointList.empty());
if(mainWindow) mainWindow->dbState(getDirty());
}
return true;
}
@@ -133,7 +125,7 @@ bool DBBrowserDB::revert(const QString& pointname)
query = QString("RELEASE %1;").arg(pointname);
sqlite3_exec(_db, query.toUtf8(), NULL, NULL, NULL);
savepointList.removeAll(pointname);
setDirty(!savepointList.empty());
if(mainWindow) mainWindow->dbState(getDirty());
}
return true;
}
@@ -191,7 +183,6 @@ bool DBBrowserDB::create ( const QString & db)
if (SQLITE_OK==sqlite3_exec(_db,"PRAGMA show_datatypes = ON;",
NULL,NULL,NULL)){
ok=true;
setDirty(false);
}
curDBFilename = db;
}
@@ -223,6 +214,7 @@ void DBBrowserDB::close (){
_db = 0;
objMap.clear();
savepointList.clear();
if(mainWindow) mainWindow->dbState(getDirty());
}
bool DBBrowserDB::dump(const QString& filename)