From f728ff73ab18fe038c457fa2fb392fdd892dc808 Mon Sep 17 00:00:00 2001 From: Martin Kleusberg Date: Mon, 23 Jan 2017 22:08:19 +0100 Subject: [PATCH] Remove useless function in Edit Table dialog --- src/EditTableDialog.cpp | 15 ++------------- src/EditTableDialog.h | 3 --- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/EditTableDialog.cpp b/src/EditTableDialog.cpp index f7d725ce..17b858b1 100644 --- a/src/EditTableDialog.cpp +++ b/src/EditTableDialog.cpp @@ -257,7 +257,7 @@ void EditTableDialog::itemChanged(QTreeWidgetItem *item, int column) { case kName: // When a field of that name already exists, show a warning to the user and don't apply the new name - if(fieldNameExists(item->text(column))) + if(m_table.findField(item->text(column))) { QMessageBox::warning(this, qApp->applicationName(), tr("There already is a field with that name. Please rename it first or choose a different " "name for this field.")); @@ -504,7 +504,7 @@ void EditTableDialog::addField() { field_name = "Field" + QString::number(field_number); field_number++; - } while(fieldNameExists(field_name)); + } while(m_table.findField(field_name)); tbitem->setText(kName, field_name); } @@ -729,14 +729,3 @@ void EditTableDialog::setTemporary(bool is_temp) } } } - -bool EditTableDialog::fieldNameExists(const QString& name) -{ - foreach(const sqlb::FieldPtr& ptr, m_table.fields()) - { - if(ptr->name() == name) - return true; - } - - return false; -} diff --git a/src/EditTableDialog.h b/src/EditTableDialog.h index 15829ba9..64ebeaeb 100644 --- a/src/EditTableDialog.h +++ b/src/EditTableDialog.h @@ -42,9 +42,6 @@ private: void moveCurrentField(bool down); - // Returns true if there already is a field of that name - bool fieldNameExists(const QString& name); - private slots: void populateFields(); void addField();