mirror of
https://github.com/sqlitebrowser/sqlitebrowser.git
synced 2026-04-29 00:19:15 -05:00
Unify message in About dialog and version argument
And avoid removing extension when printing command name in help message. See issue #1069
This commit is contained in:
+1
-14
@@ -1,6 +1,5 @@
|
|||||||
#include "AboutDialog.h"
|
#include "AboutDialog.h"
|
||||||
#include "ui_AboutDialog.h"
|
#include "ui_AboutDialog.h"
|
||||||
#include "sqlitedb.h"
|
|
||||||
#include "Application.h"
|
#include "Application.h"
|
||||||
|
|
||||||
AboutDialog::AboutDialog(QWidget *parent) :
|
AboutDialog::AboutDialog(QWidget *parent) :
|
||||||
@@ -10,19 +9,7 @@ AboutDialog::AboutDialog(QWidget *parent) :
|
|||||||
ui->setupUi(this);
|
ui->setupUi(this);
|
||||||
this->setFixedSize(this->width(), this->height());
|
this->setFixedSize(this->width(), this->height());
|
||||||
this->setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
|
this->setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
|
||||||
|
ui->label_version->setText(Application::versionInformation());
|
||||||
QString sqlite_version, sqlcipher_version;
|
|
||||||
DBBrowserDB::getSqliteVersion(sqlite_version, sqlcipher_version);
|
|
||||||
if(sqlcipher_version.isNull())
|
|
||||||
sqlite_version = tr("SQLite Version ") + sqlite_version;
|
|
||||||
else
|
|
||||||
sqlite_version = tr("SQLCipher Version %1 (based on SQLite %2)").arg(sqlcipher_version, sqlite_version);
|
|
||||||
|
|
||||||
ui->label_version->setText(tr("Version ") + Application::versionString() + "\n\n" +
|
|
||||||
tr("Built for %1, running on %2").arg(QSysInfo::buildAbi(), QSysInfo::currentCpuArchitecture()) + "\n\n" +
|
|
||||||
tr("Qt Version ") + QT_VERSION_STR + "\n\n" +
|
|
||||||
sqlite_version
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
AboutDialog::~AboutDialog()
|
AboutDialog::~AboutDialog()
|
||||||
|
|||||||
+20
-2
@@ -13,6 +13,7 @@
|
|||||||
#include "RemoteNetwork.h"
|
#include "RemoteNetwork.h"
|
||||||
#include "Settings.h"
|
#include "Settings.h"
|
||||||
#include "version.h"
|
#include "version.h"
|
||||||
|
#include "sqlitedb.h"
|
||||||
|
|
||||||
Application::Application(int& argc, char** argv) :
|
Application::Application(int& argc, char** argv) :
|
||||||
QApplication(argc, argv)
|
QApplication(argc, argv)
|
||||||
@@ -90,7 +91,7 @@ Application::Application(int& argc, char** argv) :
|
|||||||
{
|
{
|
||||||
// Help
|
// Help
|
||||||
qWarning() << qPrintable(tr("Usage: %1 [options] [<database>|<project>]\n").
|
qWarning() << qPrintable(tr("Usage: %1 [options] [<database>|<project>]\n").
|
||||||
arg(QFileInfo(argv[0]).baseName()));
|
arg(QFileInfo(argv[0]).fileName()));
|
||||||
qWarning() << qPrintable(tr("Possible command line arguments:"));
|
qWarning() << qPrintable(tr("Possible command line arguments:"));
|
||||||
qWarning() << qPrintable(tr(" -h, --help Show command line options"));
|
qWarning() << qPrintable(tr(" -h, --help Show command line options"));
|
||||||
qWarning() << qPrintable(tr(" -q, --quit Exit application after running scripts"));
|
qWarning() << qPrintable(tr(" -q, --quit Exit application after running scripts"));
|
||||||
@@ -106,7 +107,7 @@ Application::Application(int& argc, char** argv) :
|
|||||||
qWarning() << qPrintable(tr(" <project> Open this project file (*.sqbpro)"));
|
qWarning() << qPrintable(tr(" <project> Open this project file (*.sqbpro)"));
|
||||||
m_dontShowMainWindow = true;
|
m_dontShowMainWindow = true;
|
||||||
} else if(arguments().at(i) == "-v" || arguments().at(i) == "--version") {
|
} else if(arguments().at(i) == "-v" || arguments().at(i) == "--version") {
|
||||||
qWarning() << qPrintable(tr("DB Browser for SQLite version %1.").arg(versionString()));
|
qWarning() << qPrintable(versionInformation());
|
||||||
m_dontShowMainWindow = true;
|
m_dontShowMainWindow = true;
|
||||||
} else if(arguments().at(i) == "-s" || arguments().at(i) == "--sql") {
|
} else if(arguments().at(i) == "-s" || arguments().at(i) == "--sql") {
|
||||||
// Run SQL file: If file exists add it to list of scripts to execute
|
// Run SQL file: If file exists add it to list of scripts to execute
|
||||||
@@ -227,6 +228,23 @@ QString Application::versionString()
|
|||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
||||||
|
QString Application::versionInformation()
|
||||||
|
{
|
||||||
|
QString sqlite_version, sqlcipher_version;
|
||||||
|
DBBrowserDB::getSqliteVersion(sqlite_version, sqlcipher_version);
|
||||||
|
if(sqlcipher_version.isNull())
|
||||||
|
sqlite_version = tr("SQLite Version ") + sqlite_version;
|
||||||
|
else
|
||||||
|
sqlite_version = tr("SQLCipher Version %1 (based on SQLite %2)").arg(sqlcipher_version, sqlite_version);
|
||||||
|
|
||||||
|
return
|
||||||
|
tr("DB Browser for SQLite Version %1.").arg(versionString() + "\n\n" +
|
||||||
|
tr("Built for %1, running on %2").arg(QSysInfo::buildAbi(), QSysInfo::currentCpuArchitecture()) + "\n" +
|
||||||
|
tr("Qt Version %1").arg(QT_VERSION_STR) + "\n" +
|
||||||
|
sqlite_version
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
void Application::reloadSettings()
|
void Application::reloadSettings()
|
||||||
{
|
{
|
||||||
// Network settings
|
// Network settings
|
||||||
|
|||||||
@@ -21,7 +21,10 @@ public:
|
|||||||
|
|
||||||
MainWindow* mainWindow() { return m_mainWindow; }
|
MainWindow* mainWindow() { return m_mainWindow; }
|
||||||
|
|
||||||
|
// DB4S version number as string
|
||||||
static QString versionString();
|
static QString versionString();
|
||||||
|
// Version of DB4S and dependencies as string
|
||||||
|
static QString versionInformation();
|
||||||
|
|
||||||
static void reloadSettings();
|
static void reloadSettings();
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user