From ff86e525b38774d0c4774a4bb4350b44e9782037 Mon Sep 17 00:00:00 2001 From: mgrojo Date: Mon, 30 Dec 2019 20:48:58 +0100 Subject: [PATCH] Optimize simplification of Schema column According to documentation https://doc.qt.io/qt-5/qstring.html#simplified > Whitespace means any character for which QChar::isSpace() returns true. > This includes the ASCII characters '\t', '\n', '\v', '\f', '\r', and ' '. So replacing '\n' is redundant and can be removed without effect. --- src/DbStructureModel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/DbStructureModel.cpp b/src/DbStructureModel.cpp index 43cb3d87..7ca68b7c 100644 --- a/src/DbStructureModel.cpp +++ b/src/DbStructureModel.cpp @@ -52,7 +52,7 @@ QVariant DbStructureModel::data(const QModelIndex& index, int role) const if(index.column() == ColumnName && item->parent() == browsablesRootItem) return QString::fromStdString(sqlb::ObjectIdentifier(item->text(ColumnSchema).toStdString(), item->text(ColumnName).toStdString()).toDisplayString()); else - return Settings::getValue("db", "hideschemalinebreaks").toBool() ? item->text(index.column()).replace("\n", " ").simplified() : item->text(index.column()); + return Settings::getValue("db", "hideschemalinebreaks").toBool() ? item->text(index.column()).simplified() : item->text(index.column()); case Qt::EditRole: return item->text(index.column()); case Qt::ToolTipRole: {