Commit Graph

2787 Commits

Author SHA1 Message Date
Navdeep Singh Sidhu 21c6ea05fb Merge pull request #7 from sqlitebrowser/master
Changes from upstream before PR
2018-12-29 19:05:01 -06:00
Navdeep Singh Sidhu da3db8bfbf AppImage built support via Travis using xenial
* Updated travis config to use xenial instead of trusty
* Added support to build x86_64 AppImage
2018-12-29 19:02:04 -06:00
mgrojo 1925ccfd37 Make the Edit Cell Dock to update with the selected cell in SQL results
The same connection done for the Browse Data table is done for the SQL
results table so they behave in the same way.

See issue #481
2018-12-28 18:11:44 +01:00
mgrojo a9de3d87e3 Fix tabs not showing in a clean installation
If there are no settings previously stored for the MainWindow/openTabs, the
default empty string was converted to a list of one empty string and
consequently all tabs were cleared and none added.

This fixes all possible cases where the list of open tabs is empty. It
means: do not make changes, as originally designed (since the setting for
all tabs closed doesn't make sense).

See issue #1692 (and #1675 for the enhancement).
2018-12-28 15:47:11 +01:00
mgrojo 8f59d3aed6 Make Ctrl+T shortcut to work for "Open tab" in "Execute SQL"
This shortcut was set for the following actions, making it ambiguous:
"View > DB Toolbar" and "Open tab" in "Execute SQL". Additionally it was
used by QScintilla for transposing lines.

Shortcut for "View > DB Toolbar" has been removed, since it's not
considered a frequently used action and there are other toolbars without
shortcut. The shortcut for QScintilla has been changed to "Ctrl+Shift+Up".

The now working shortcut is added to the "Open tab" action's tool-tip for
documentation purposes.

See issue #1647
2018-12-28 13:04:17 +01:00
mgrojo 0ffed5e287 Fix shortcuts Alt+[1-4] switching to that tab
Using QShortcut this shortcuts are working in any context. With the
previous approach there were problems in QScintilla widgets, in the Browse
table combo-box and probably others.

See issue #788
2018-12-27 17:45:45 +01:00
mgrojo ea5a32c37b Fix ambiguous shortcut for Ctrl+O
Ctrl+O for opening a database file did no longer work. It raised this
warning:

QAction::eventFilter: Ambiguous shortcut overload: Ctrl+O

The shortcut was repeated in the UI.

This bug was introduced by e11b32ed54

It was laterally reported in #459
2018-12-27 16:22:41 +01:00
Martin Kleusberg 45a82252e1 Fix possible resource leaks
See issue #1691.
2018-12-27 11:55:21 +01:00
Martin Kleusberg 730b494ce7 Show warning when closing the database fails 2018-12-27 11:30:53 +01:00
mgrojo 544ed812e2 Reset Window Layout, positional shortcuts for tabs and avoid statusTip
- New action (Alt+0) in View menu for resetting window layout (main tabs,
toolbars and docks).
- Shortcuts for tabs use positional meaning: after moving the tabs, the
number always refers to the position of the tab, and not the identity.
- Avoid using statusTip for restoring the original tab label and use
accesibleName, which is believed to be either neutral, when set, or
beneficial.
- Assure the tab is open when some function switches to it: browse table
and SQLite checks.
- Avoid flickering while clearing and adding tabs.

See issue #1675
2018-12-26 19:04:09 +01:00
mgrojo b89adc4122 Save open tabs state in project files
The ordered set of open tabs is saved in the project file using a new
element main_tabs with attributes open (ordered list of open tabs like the
"MainWindow/openTabs" setting) and current (the current index inside that
set).

When the project load code finds the old element (current_tab) it falls
back to restoring all the main tabs and then setting that tab index as
current. In this way, old project files are restored as they were saved,
even when the user has closed or moved some tabs.

See issue #1675.
2018-12-26 15:03:11 +01:00
Martin Kleusberg fc8f23f299 Add a comment about a problem we should fix one day 2018-12-26 13:46:28 +01:00
Martin Kleusberg 285e0ef49e Remove unused code and fix a warning 2018-12-26 13:38:42 +01:00
Martin Kleusberg 7f597d07e4 Fix handling of custom rowids/pseudo PKs
This should avoid double queries in the Browse Data tab for views and
for tables.
2018-12-26 13:35:11 +01:00
mgrojo 4f9c21f83f Closable main tabs and saving automatically open tabs and order
Main tabs are made closable, so they can be closed by the user. New entries
are added to the View menu for toggling their open/closed state.

Spartan users can closed all tabs but their preferred, and then the tab bar
is hidden saving some space.

The set of open tabs and their order is automatically saved in the settings
on application exit and restored on application start.

Tab labels are stored in the statusTip attribute in order to restore them,
since those labels are not stored anywhere else.

See issues #1675 and #459
2018-12-25 21:12:28 +01:00
Martin Kleusberg 79ffd779b9 Show current platform and destination platform information
Add the destination platform from the compilation process and the
platform we are running on to the About dialog and the Bug Report
template text.

See issue #1660.
2018-12-25 19:42:55 +01:00
Martin Kleusberg c8ef76241d Do not recreate table schema if table did not change
When the table schema was not modified in the Edit Table dialog, do not
do anything when clicking the OK button.

See issue #1686.
2018-12-25 18:51:36 +01:00
Martin Kleusberg 094a6a624a Fix plot
Fix a plot bug introduced in 37a5645bf5 by
an oversight.

See issue #1679.
2018-12-25 18:46:29 +01:00
Martin Kleusberg 73f7cc824f Fix 195d8683e5
Some parts of the code were still using indices instead of widget
pointers for referencing the main window tabs.
2018-12-25 17:50:11 +01:00
Justin Clift dd1878c81e Use Qt 5.11.3 for the macOS builds too
This is due to a weird word wrapping bug present in Qt 5.12.0.

We'll use the Qt 5.11.x releases for now, until a solution to the
problem is found.
2018-12-24 21:51:12 +11:00
mgrojo 195d8683e5 Enable the movable attribute for main tabs
The movable attribute for the main tabs is enabled and the code is adapted
to use widget references instead of indices.

This allows user to move tabs and set a preferred order, but the order is
still not saved.

See issue #1675
2018-12-24 00:56:44 +01:00
zvova7890 a983248931 Change UI size policy, make RU translation shorter (#1678)
The width of the UI elements is forced by the text in buttons. This is a problem in some translations,
where the text are longer than the original. This PR address this tweaking some aspects:

* change UI size policy

* make RU translation for some buttons shorter

* move Set as NULL to bottom in EditDialog
2018-12-23 12:31:06 +01:00
Navdeep Singh Sidhu 322fe3c381 Experiment 6.0 for AppImage
Debugging version number command for travis
2018-12-22 21:21:48 -06:00
Navdeep Singh Sidhu 4d2fa9303a Set Branch to build on 2018-12-22 15:41:29 -06:00
Navdeep Singh Sidhu 4bfcf8bdb3 Experiment 5.1 for AppImage
Experiment 5.1 for AppImage
2018-12-22 09:26:08 -06:00
Navdeep Singh Sidhu f17f333db6 Experiment 5.0 for AppImage
Upgrading script to xenial
2018-12-22 09:18:21 -06:00
Justin Clift 573bcdb7d0 Use Qt 5.11.3 for our Win64 nightly builds 2018-12-22 22:44:15 +11:00
Justin Clift 21ce868fef Update SQLCipher version used by the nightly build scripts
These versions are a copy of the ones actually used, so changes
can sometimes lag.
2018-12-21 08:17:39 +11:00
mgrojo cfdf68d562 Use a specialised count query for browsing tables/views
For queries built from a table and filters, use a specialised count query
that only takes into account the where part of the statement. This will
speed-up the Browse Data tab for big tables.

See issue #1666
2018-12-20 10:49:22 +01:00
mgrojo b4667b6bac Change the maximum size of the SQL results pane to a more flexible approach
Set a default equal to the previous maximum, but allow user to grow this
pane to any value, permitted by the other widgets.

See issue #1670
2018-12-18 22:53:56 +01:00
Navdeep Singh Sidhu 587eab4f98 Experiment 4.0 for AppImage
Changed Version Number to be consistent with snap packages
2018-12-16 14:02:50 -06:00
Navdeep Singh Sidhu 2a84e02ee0 Experiment 4.0 for AppImage 2018-12-16 12:07:20 -06:00
Navdeep Singh Sidhu 0b500c03ce Experiment 3.0 for AppImage 2018-12-16 11:15:11 -06:00
Navdeep Singh Sidhu 608444069b Experiment 2.0 for AppImage 2018-12-16 10:54:32 -06:00
Navdeep Singh Sidhu bd5538d2a6 Experiment 1.0 for Appimage 2018-12-16 10:07:12 -06:00
Navdeep Singh Sidhu 122ce98ba0 changes to travis file toBuild Appimage 2018-12-15 23:31:13 -06:00
mgr f2ff1472a8 Load all data when select all is requested
selectAll is overridden so all data is actually selected. Warn and ask user
as this may take some time and consume lots of memory (when the table is
big).

See issue #1373
2018-12-15 18:09:13 +01:00
Justin Clift df33455fda Generate a new .ts file for Persian
It's not yet hooked into the build process, which can come later.
2018-12-15 14:49:09 +11:00
Justin Clift 66c2ad10c0 Fix a misleading error message typo
Also tweaked the message wording slightly, to make it sound more
natural.
2018-12-14 20:00:46 +11:00
mgrojo 256ae36a13 Do not show more than 512 characters in DB Structure tooltips
Truncate the SQL create sentence when it is longer than 512 characters
and pad with "...".

See issue #1659
2018-12-14 00:29:23 +01:00
Iulian Onofrei 1af7b031ea Removed dead code 2018-12-13 11:26:10 +02:00
Justin Clift 790110206e Include the math extension with our macOS nightly build 2018-12-13 18:02:28 +11:00
Justin Clift ee4518cd7b Build our macOS nightlies using SQLCipher 4.0.0 2018-12-13 16:57:38 +11:00
Justin Clift 66e3322088 Add macOS .dylib extension to the extension selector dialog 2018-12-13 16:50:45 +11:00
Karim ElDeeb ffb07e1f23 Disable running the application after installation on Windows
See issue #1656.
2018-12-12 17:08:48 +02:00
Martin Kleusberg 035bc161f9 dbhub: Redesign the Remote teb of the Preferences dialog
The new layout hopefully makes it a bit easier to understand how to use
the dialog.
2018-12-12 14:23:50 +01:00
Martin Kleusberg d86b45e7e6 dbhub: Open Preferences dialog on the correct tab
When opening the Preferences dialog from the Remote dock, we now show
the Remote tab by default.
2018-12-12 14:23:44 +01:00
Martin Kleusberg 88ce4acf97 sqlcipher: Add new encryption settings to improve support for SQLCipher4
This adds three new settings to the cipher dialog: KDF iterations, HMAC
algorithm, and KDF algorithm. To simplify things we also add two presets
for all the encryption settings: SQLCipher3 defaults and SQLCipher4
defaults. The preselected default is chosen depending on the SQLCipher
version which we use.

This should work with any combination of SQLCipher3 and SQLCipher4 and
any database created by either. It should also work with DotEnv files as
expected. Again, the defaults which are used for missing values in the
DotEnv files are chosen depending on the SQLCipher version we use.
2018-12-12 13:41:47 +01:00
Justin Clift 2c8883d540 Use our temporary SQLCipher 3.4.2 Homebrew tap
This is just until we get some things for SQLCipher 4.0.x worked
out.
2018-12-12 13:04:19 +11:00
Justin Clift ac5551458d Fix a bad cut-n-paste
We don't go a git pull of the sqlitebrowser repo for the SQLCipher
build, else the SQLite and SQLCipher builds could differ in the
commits they'd done with.
2018-12-12 00:27:07 +11:00