From 32e2a011eedb2a44f0a7d11a73d04f08a15d8f7b Mon Sep 17 00:00:00 2001 From: Francesco Mazzoli Date: Tue, 8 Aug 2023 09:27:44 +0000 Subject: [PATCH] More grafana fixes --- cpp/cdc/CDC.cpp | 2 +- go/eggsshuckle/stats.html | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cpp/cdc/CDC.cpp b/cpp/cdc/CDC.cpp index a5cc2cdf..f2f1b645 100644 --- a/cpp/cdc/CDC.cpp +++ b/cpp/cdc/CDC.cpp @@ -750,7 +750,7 @@ public: for (int i = 0; i < errs.count.size(); i++) { uint64_t count = errs.count[i].load(); if (count == 0) { continue; } - _metricsBuilder.measurement("eggsfs_shard_requests"); + _metricsBuilder.measurement("eggsfs_cdc_requests"); _metricsBuilder.tag("kind", kind); if (i == 0) { _metricsBuilder.tag("error", "NO_ERROR"); diff --git a/go/eggsshuckle/stats.html b/go/eggsshuckle/stats.html index 1fafa8cf..ac1104a6 100644 --- a/go/eggsshuckle/stats.html +++ b/go/eggsshuckle/stats.html @@ -1,5 +1,8 @@ {{define "body"}}
+

+ This page contains latency histograms, for other live stats, head to Grafana. +

The CDC stats include both the end-to-end latency (from request parse to response sent), which includes the time the request spent in the CDC transaction queue; and the "process" time (.process), which is how long it took to process the request from transaction start to transaction finish.