Wait forever, rather than having timeouts

The goal here is to not have constant wakeups due to timeout. Do
not attempt to clean things up nicely before termination -- just
terminate instead. We can setup a proper termination system in
the future, I first want to see if this makes a difference.

Also, change xmon to use pipes for communication, so that it can
wait without timers as well.

Also, `write` directly for logging, so that we know the logs will
make it to the file after the logging call returns (since we now
do not have the chance to flush them afterwards).
This commit is contained in:
Francesco Mazzoli
2023-12-05 10:19:21 +00:00
committed by Francesco Mazzoli
parent 5d53959e18
commit 38f3d54ecd
26 changed files with 666 additions and 632 deletions

55
cpp/core/XmonAgent.cpp Normal file
View File

@@ -0,0 +1,55 @@
#include "XmonAgent.hpp"
#include "Assert.hpp"
#include "Exception.hpp"
struct XmonRequestHeader {
XmonRequestType msgType;
int64_t alertId;
Duration quietPeriod;
bool binnable;
uint16_t messageLen;
};
void XmonRequest::write(int fd) const {
ALWAYS_ASSERT(message.size() < 1<<16);
XmonRequestHeader header = {
.msgType = msgType,
.alertId = alertId,
.quietPeriod = quietPeriod,
.binnable = binnable,
.messageLen = (uint16_t)message.size(),
};
static thread_local char buf[PIPE_BUF];
ALWAYS_ASSERT(sizeof(header) + header.messageLen < PIPE_BUF);
memcpy(buf, &header, sizeof(header));
memcpy(buf+sizeof(header), message.data(), header.messageLen);
{
// pipe writes of < PIPE_BUF are guaranteed to be atomic, see pipe(7)
int written = ::write(fd, buf, sizeof(header)+header.messageLen);
if (written != sizeof(header)+header.messageLen) {
throw SYSCALL_EXCEPTION("write");
}
}
}
bool XmonRequest::read(int fd) {
static thread_local char buf[PIPE_BUF];
XmonRequestHeader header;
int read = ::read(fd, buf, sizeof(header));
if (read < 0 && errno == EAGAIN) { return false; }
if (read != sizeof(header)) {
throw SYSCALL_EXCEPTION("read");
}
memcpy(&header, buf, sizeof(header));
msgType = header.msgType;
alertId = header.alertId;
quietPeriod = header.quietPeriod;
binnable = header.binnable;
read = ::read(fd, buf, header.messageLen);
if (read != header.messageLen) {
throw SYSCALL_EXCEPTION("read");
}
buf[header.messageLen] = '\0';
message = std::string(buf);
return true;
}