From 7f7374b71a9fd2445ee9dcbd8de0ebcf44774f7d Mon Sep 17 00:00:00 2001 From: Guillaume Chau Date: Sat, 12 May 2018 03:55:36 +0200 Subject: [PATCH] fix(ui): more strings localized --- .../cli-ui/src/components/ProjectFeatureItem.vue | 5 +++-- .../cli-ui/src/components/ProjectPresetItem.vue | 5 +++-- .../cli-ui/src/graphql-api/connectors/projects.js | 12 ++++++------ packages/@vue/cli/locales/en.json | 15 ++++++++++++++- 4 files changed, 26 insertions(+), 11 deletions(-) diff --git a/packages/@vue/cli-ui/src/components/ProjectFeatureItem.vue b/packages/@vue/cli-ui/src/components/ProjectFeatureItem.vue index c98282c53..bc5f0e5a6 100644 --- a/packages/@vue/cli-ui/src/components/ProjectFeatureItem.vue +++ b/packages/@vue/cli-ui/src/components/ProjectFeatureItem.vue @@ -4,14 +4,15 @@ :class="{ selected: feature.enabled }" + :data-id="feature.id" > diff --git a/packages/@vue/cli-ui/src/components/ProjectPresetItem.vue b/packages/@vue/cli-ui/src/components/ProjectPresetItem.vue index 72cbc231f..c412a0af8 100644 --- a/packages/@vue/cli-ui/src/components/ProjectPresetItem.vue +++ b/packages/@vue/cli-ui/src/components/ProjectPresetItem.vue @@ -4,6 +4,7 @@ :class="{ selected }" + :data-id="preset.id" >
diff --git a/packages/@vue/cli-ui/src/graphql-api/connectors/projects.js b/packages/@vue/cli-ui/src/graphql-api/connectors/projects.js index ae5f459c3..d0d5a9f72 100644 --- a/packages/@vue/cli-ui/src/graphql-api/connectors/projects.js +++ b/packages/@vue/cli-ui/src/graphql-api/connectors/projects.js @@ -44,7 +44,7 @@ function getLast (context) { } function generatePresetDescription (preset) { - let description = `Features: ${preset.features.join(', ')}` + let description = preset.features.join(', ') if (preset.raw.useConfigFiles) { description += ` (Use config files)` } @@ -94,7 +94,7 @@ async function initCreator (context) { ) const info = { id: key, - name: key === 'default' ? 'Default preset' : key, + name: key === 'default' ? 'views.project-create.tabs.presets.default-preset' : key, features, link: null, raw: preset @@ -105,8 +105,8 @@ async function initCreator (context) { ), { id: '__manual__', - name: 'Manual', - description: 'Manually select features', + name: 'views.project-create.tabs.presets.manual.name', + description: 'views.project-create.tabs.presets.manual.description', link: null, features: [] } @@ -127,8 +127,8 @@ async function initCreator (context) { ), { id: 'use-config-files', - name: 'Use config files', - description: `Use specific configuration files (like '.babelrc') instead of using 'package.json'.`, + name: 'views.project-create.tabs.features.userConfigFiles.name', + description: 'views.project-create.tabs.features.userConfigFiles.description', link: null, plugins: null, enabled: false diff --git a/packages/@vue/cli/locales/en.json b/packages/@vue/cli/locales/en.json index 0a146543f..11c049c73 100644 --- a/packages/@vue/cli/locales/en.json +++ b/packages/@vue/cli/locales/en.json @@ -210,7 +210,16 @@ "modal": { "title": "Configure Remote preset", "body": "Available soon..." - } + }, + "manual": { + "name": "Manual", + "description": "Manually select features" + }, + "remote": { + "name": "Remote preset", + "description": "Fetch a preset from a git repository" + }, + "default-preset": "Default preset" }, "features": { "title": "Features", @@ -220,6 +229,10 @@ "previous": "Previous", "next": "Next", "create": "Create Project" + }, + "userConfigFiles": { + "name": "Use config files", + "description": "Use specific configuration files (like '.babelrc') instead of using 'package.json'." } }, "configuration": {