fix: do not install core plugins that have major version bumps (#4720)

* fix: fix version check for core plugins in v4

* fix: fix the error when the diff result is null
This commit is contained in:
Haoqun Jiang
2019-10-21 17:20:23 +08:00
committed by GitHub
parent 85c9cbfeda
commit 96890b526f
+7 -2
View File
@@ -129,8 +129,13 @@ module.exports = class Creator extends EventEmitter {
const { current, latest } = await getVersions()
let latestMinor = `${semver.major(latest)}.${semver.minor(latest)}.0`
// if using `next` branch of cli
if (semver.gte(current, latest) && semver.prerelease(current)) {
if (
// if the latest version contains breaking changes
/major/.test(semver.diff(current, latest)) ||
// or if using `next` branch of cli
(semver.gte(current, latest) && semver.prerelease(current))
) {
// fallback to the current cli version number
latestMinor = current
}
// generate package.json with plugin dependencies